Thanks to visit codestin.com
Credit goes to github.com

Skip to content

SignatureCalculator for ning client and new version #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
vonagam opened this issue Mar 7, 2017 · 0 comments
Open

SignatureCalculator for ning client and new version #7

vonagam opened this issue Mar 7, 2017 · 0 comments

Comments

@vonagam
Copy link

vonagam commented Mar 7, 2017

As is seen here, ning removed url parameter from calculateAndAddSignature method in newer version of the library:

https://github.com/AsyncHttpClient/async-http-client/blob/1.9.x/src/main/java/com/ning/http/client/SignatureCalculator.java#L38

httpsig-java/http-helpers/src/main/java/net/adamcin/httpsig/http/ning/AsyncSignatureCalculator.java

Line 58 in 2b1fc56

public void calculateAndAddSignature(String url, Request request, RequestBuilderBase<?> requestBuilder) {

As this parameter is not used in any way by AsyncSignatureCalculator it can be simply removed to support new interface.

Can http-helpers be updated with support for newer ning client version?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vonagam