first attempt: Keep the target of WeakReference alive, otherwise the produced output may be different.

adamsitnik · adamsitnik · commit 641d6cdb2e77 · 2024-07-18T11:11:56.000+02:00
diff --git a/src/libraries/System.Resources.Extensions/tests/BinaryFormatTests/FormattedObject/BasicObjectTests.cs b/src/libraries/System.Resources.Extensions/tests/BinaryFormatTests/FormattedObject/BasicObjectTests.cs
@@ -14,6 +14,9 @@ public class BasicObjectTests : Common.BasicObjectTests<FormattedObjectSerialize
     [MemberData(nameof(SerializableObjects))]
     public void BasicObjectsRoundTripAndMatch(object value, TypeSerializableValue[] _)
     {
+        // Keep the target of WeakReference alive, otherwise the produced output may be different.
+        object keepAlive = value is WeakReference weakReference ? weakReference.Target : null;
+
         // We need to round trip through the BinaryFormatter as a few objects in tests remove
         // serialized data on deserialization.
         BinaryFormatter formatter = new();
@@ -38,5 +41,7 @@ public void BasicObjectsRoundTripAndMatch(object value, TypeSerializableValue[]
 
         // Now compare the two streams to ensure they are identical
         Assert.Equal(serialized.Length, deserializedSerialized.Length);
+
+        GC.KeepAlive(keepAlive);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,9 @@ public class BasicObjectTests : Common.BasicObjectTests<FormattedObjectSerialize`
`14`	`14`	`[MemberData(nameof(SerializableObjects))]`
`15`	`15`	`public void BasicObjectsRoundTripAndMatch(object value, TypeSerializableValue[] _)`
`16`	`16`	`{`
	`17`	`+ // Keep the target of WeakReference alive, otherwise the produced output may be different.`
	`18`	`+ object keepAlive = value is WeakReference weakReference ? weakReference.Target : null;`
	`19`	`+`
`17`	`20`	`// We need to round trip through the BinaryFormatter as a few objects in tests remove`
`18`	`21`	`// serialized data on deserialization.`
`19`	`22`	`BinaryFormatter formatter = new();`
`@@ -38,5 +41,7 @@ public void BasicObjectsRoundTripAndMatch(object value, TypeSerializableValue[]`
`38`	`41`
`39`	`42`	`// Now compare the two streams to ensure they are identical`
`40`	`43`	`Assert.Equal(serialized.Length, deserializedSerialized.Length);`
	`44`	`+`
	`45`	`+ GC.KeepAlive(keepAlive);`
`41`	`46`	`}`
`42`	`47`	`}`