Test failures in 4.0.2 #1805
Description
Hi,
We've recently upgraded afdko to 4.0.2 in Guix, but it seems there are now test failures (it's unclear why I didn't catch those before upgrading the package -- potentially they were caused by some other update, or are non-deterministic):
=================================== FAILURES ===================================
_ test_type1_supported_hint[/tmp/guix-build-python-afdko-4.0.2.drv-0/afdko-4.0.2/tests/otfautohint_data/input/dummy/font.ps] _
[gw2] linux -- Python 3.11.11 /gnu/store/v76lvm9985mj5h3kwrkif7gnqv3q30ck-python-wrapper-3.11.11/bin/python
path = '/tmp/guix-build-python-afdko-4.0.2.drv-0/afdko-4.0.2/tests/otfautohint_data/input/dummy/font.ps'
@pytest.mark.parametrize("path", glob.glob(get_input_path("dummy/font.p*")))
def test_type1_supported_hint(path):
out_path = get_temp_file_path()
options = OTFOptions(path, out_path)
if os.path.basename(path) == 'font.ps':
options.ignoreFontinfo = True
hintFiles(options)
path_dump = get_temp_file_path()
out_dump = get_temp_file_path()
subprocess.check_call(["tx", "-dump", "-6", path, path_dump])
subprocess.check_call(["tx", "-dump", "-6", out_path, out_dump])
> assert differ([path_dump, out_dump])
E AssertionError: assert False
E + where False = differ(['/tmp/guix-build-python-afdko-4.0.2.drv-0/tmp70nhe84s', '/tmp/guix-build-python-afdko-4.0.2.drv-0/tmp1hi9zbq4'])
tests/otfautohint_test.py:577: AssertionError
----------------------------- Captured stdout call -----------------------------
--- /tmp/guix-build-python-afdko-4.0.2.drv-0/tmp70nhe84s
+++ /tmp/guix-build-python-afdko-4.0.2.drv-0/tmp1hi9zbq4
@@ -3459,2 +3459,3 @@
718 topedge
+ 780 841 hstem
53 140 vstem
@@ -9054,2 +9055,3 @@
714 topedge
+ 752 802 hstem
81 161 vstem
@@ -9064,2 +9066,3 @@
714 topedge
+ 752 802 hstem
81 161 vstem
@@ -9072,2 +9075,3 @@
714 topedge
+ 752 802 hstem
81 161 vstem
@@ -20932,2 +20936,3 @@
714 topedge
+ 752 802 hstem
60 145 vstem
@@ -20942,2 +20947,3 @@
714 topedge
+ 752 802 hstem
60 145 vstem
@@ -20950,2 +20956,3 @@
714 topedge
+ 752 802 hstem
60 145 vstem
@@ -20959,2 +20966,3 @@
714 topedge
+ 752 802 hstem
60 145 vstem
______________________________ test_decimals_ufo _______________________________
[gw2] linux -- Python 3.11.11 /gnu/store/v76lvm9985mj5h3kwrkif7gnqv3q30ck-python-wrapper-3.11.11/bin/python
def test_decimals_ufo():
path = get_input_path("dummy/decimals.ufo")
out_path = get_temp_dir_path()
options = OTFOptions(path, out_path)
options.roundCoords = False
hintFiles(options)
> assert differ([path, out_path])
E AssertionError: assert False
E + where False = differ(['/tmp/guix-build-python-afdko-4.0.2.drv-0/afdko-4.0.2/tests/otfautohint_data/input/dummy/decimals.ufo', '/tmp/guix-build-python-afdko-4.0.2.drv-0/tmp46cibv5p'])
tests/otfautohint_test.py:821: AssertionError
----------------------------- Captured stdout call -----------------------------
--- /tmp/guix-build-python-afdko-4.0.2.drv-0/afdko-4.0.2/tests/otfautohint_data/input/dummy/decimals.ufo/glyphs.com.adobe.type.processedglyphs/braceleft.glif
+++ /tmp/guix-build-python-afdko-4.0.2.drv-0/tmp46cibv5p/glyphs.com.adobe.type.processedglyphs/braceleft.glif
@@ -14,6 +14,6 @@
<point x="142.4" y="-11.2" type="curve"/>
- <point x="142.4" y="37.6"/>
+ <point x="142.4" y="37.6" name="hintRef0001"/>
<point x="147.2" y="79.2"/>
<point x="147.2" y="133.6" type="curve"/>
- <point x="147.2" y="184.8" name="hintRef0001"/>
+ <point x="147.2" y="184.8" name="hintRef0002"/>
<point x="133.6" y="211.2"/>
@@ -24,6 +24,6 @@
<point x="147.2" y="311.2" type="curve"/>
- <point x="147.2" y="365.6" name="hintRef0002"/>
+ <point x="147.2" y="365.6"/>
<point x="142.4" y="407.2"/>
<point x="142.4" y="456" type="curve"/>
- <point x="142.4" y="508"/>
+ <point x="142.4" y="508" name="hintRef0003"/>
<point x="153.6" y="528.8"/>
@@ -36,13 +36,13 @@
<point x="88.8" y="460" type="curve"/>
- <point x="88.8" y="401.6"/>
+ <point x="88.8" y="401.6" name="hintRef0004"/>
<point x="96" y="359.2"/>
<point x="96" y="304.8" type="curve"/>
- <point x="96" y="274.4" name="hintRef0003"/>
+ <point x="96" y="274.4"/>
<point x="81.6" y="244"/>
<point x="27.2" y="243.2" type="curve"/>
- <point x="27.2" y="201.6" type="line"/>
- <point x="81.6" y="200.8"/>
+ <point x="27.2" y="201.6" type="line" name="hintRef0005"/>
+ <point x="81.6" y="200.8" name="hintRef0006"/>
<point x="96" y="170.4"/>
<point x="96" y="139.2" type="curve"/>
- <point x="96" y="85.6" name="hintRef0004"/>
+ <point x="96" y="85.6"/>
<point x="88.8" y="43.2"/>
@@ -78,3 +78,3 @@
<string>hstem 528.8 37.6</string>
- <string>vstem 27.2 72</string>
+ <string>vstem 96 51.2</string>
</array>
@@ -89,3 +89,3 @@
<string>hstem 528.8 37.6</string>
- <string>vstem 88.8 53.6</string>
+ <string>vstem 96 51.2</string>
</array>
@@ -100,3 +100,3 @@
<string>hstem 528.8 37.6</string>
- <string>vstem 27.2 72</string>
+ <string>vstem 88.8 53.6</string>
</array>
@@ -111,3 +111,25 @@
<string>hstem 528.8 37.6</string>
- <string>vstem 88.8 53.6</string>
+ <string>vstem 96 51.2</string>
+ </array>
+ </dict>
+ <dict>
+ <key>pointTag</key>
+ <string>hintRef0005</string>
+ <key>stems</key>
+ <array>
+ <string>hstem -121.6 37.6</string>
+ <string>hstem 201.6 41.6</string>
+ <string>hstem 528.8 37.6</string>
+ <string>vstem 27.2 72</string>
+ </array>
+ </dict>
+ <dict>
+ <key>pointTag</key>
+ <string>hintRef0006</string>
+ <key>stems</key>
+ <array>
+ <string>hstem -121.6 37.6</string>
+ <string>hstem 201.6 41.6</string>
+ <string>hstem 528.8 37.6</string>
+ <string>vstem 96 51.2</string>
</array>
=============================== warnings summary ===============================
../../../gnu/store/bbfi42m2k72hknq8gi3i6ly76q50rpzg-python-fs-2.4.16/lib/python3.11/site-packages/fs/__init__.py:4: 32 warnings
/gnu/store/bbfi42m2k72hknq8gi3i6ly76q50rpzg-python-fs-2.4.16/lib/python3.11/site-packages/fs/__init__.py:4: UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81.
__import__("pkg_resources").declare_namespace(__name__) # type: ignore
../../../gnu/store/bbfi42m2k72hknq8gi3i6ly76q50rpzg-python-fs-2.4.16/lib/python3.11/site-packages/fs/__init__.py:4: 32 warnings
/gnu/store/bbfi42m2k72hknq8gi3i6ly76q50rpzg-python-fs-2.4.16/lib/python3.11/site-packages/fs/__init__.py:4: DeprecationWarning: Deprecated call to `pkg_resources.declare_namespace('fs')`.
Implementing implicit namespace packages (as specified in PEP 420) is preferred to `pkg_resources.declare_namespace`. See https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-namespace-packages
__import__("pkg_resources").declare_namespace(__name__) # type: ignore
../../../gnu/store/bbfi42m2k72hknq8gi3i6ly76q50rpzg-python-fs-2.4.16/lib/python3.11/site-packages/fs/opener/__init__.py:6: 32 warnings
/gnu/store/bbfi42m2k72hknq8gi3i6ly76q50rpzg-python-fs-2.4.16/lib/python3.11/site-packages/fs/opener/__init__.py:6: DeprecationWarning: Deprecated call to `pkg_resources.declare_namespace('fs.opener')`.
Implementing implicit namespace packages (as specified in PEP 420) is preferred to `pkg_resources.declare_namespace`. See https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-namespace-packages
__import__("pkg_resources").declare_namespace(__name__) # type: ignore
../../../gnu/store/ym4hd0kk40y4fq6m8balv2bamfc2kib0-python-setuptools-80.9.0/lib/python3.11/site-packages/pkg_resources/__init__.py:2558: 32 warnings
/gnu/store/ym4hd0kk40y4fq6m8balv2bamfc2kib0-python-setuptools-80.9.0/lib/python3.11/site-packages/pkg_resources/__init__.py:2558: DeprecationWarning: Deprecated call to `pkg_resources.declare_namespace('fs')`.
Implementing implicit namespace packages (as specified in PEP 420) is preferred to `pkg_resources.declare_namespace`. See https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-namespace-packages
declare_namespace(parent)
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info ============================
FAILED tests/otfautohint_test.py::test_type1_supported_hint[/tmp/guix-build-python-afdko-4.0.2.drv-0/afdko-4.0.2/tests/otfautohint_data/input/dummy/font.ps] - AssertionError: assert False
+ where False = differ(['/tmp/guix-build-python-afdko-4.0.2.drv-0/tmp70nhe84s', '/tmp/guix-build-python-afdko-4.0.2.drv-0/tmp1hi9zbq4'])
FAILED tests/otfautohint_test.py::test_decimals_ufo - AssertionError: assert False
+ where False = differ(['/tmp/guix-build-python-afdko-4.0.2.drv-0/afdko-4.0.2/tests/otfautohint_data/input/dummy/decimals.ufo', '/tmp/guix-build-python-afdko-4.0.2.drv-0/tmp46cibv5p'])
===== 2 failed, 1523 passed, 8 skipped, 8 xfailed, 128 warnings in 26.22s ======
Would you have an idea of a reason these may fail like this?
The inputs used are:
[email protected] [email protected] [email protected] [email protected] [email protected]
+ [email protected] [email protected] [email protected] [email protected] [email protected]
+ [email protected] [email protected] [email protected] [email protected] [email protected]
+ [email protected] [email protected] [email protected] [email protected]
+ [email protected] [email protected] [email protected]