Help decoding multiple messages using rust by resolving #987 #991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 24, 2024 20:42
When decoding multiple messages from a single byte buffer, the second and following message decoder should offset to the new header offset plus header length.
|
Thanks @wbprime, I think this looks good. Can someone apply this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #987
Say multiple messages were encoded into a continuous byte buffer. When trying to decode the first message, we might first use a
MessageHeaderDecoderto get its templateId at offset=0, then decode its body using correspoded message decoder at offset+=headerLength. This is ok for current message decoder'sheadermethod with an implicit header offset=0. But when trying to decoder the second and following messages, theMessageHeaderDecoderstep is ok however the body decoding step usingheadermethod would fetch bytes always from the first message body, thus is not expected.This unexpected result occurs only when using message decoder's
headermethod to gain ownership. Use message decoder'swrapmethod behaves as expected.This pr is just a simple workaround, simple but works (see tests/issue_987_test.rs).