Revert AgentTabStrip to original todayPayload behavior

iamtoruk · iamtoruk · commit e2254e9237f7 · 2026-04-25T01:59:51.000+02:00
diff --git a/mac/Sources/CodeBurnMenubar/Views/AgentTabStrip.swift b/mac/Sources/CodeBurnMenubar/Views/AgentTabStrip.swift
@@ -25,9 +25,9 @@ struct AgentTabStrip: View {
         }
     }
 
-    /// Drive tab VISIBILITY from the all-provider today payload so tabs don't disappear
-    /// when switching periods or to a provider with no data. Cost values come from
-    /// store.payload (the selected period) via cost(for:).
+    /// Drive tab visibility and per-tab cost labels from the *all-provider* payload (today),
+    /// not the currently selected provider's payload. Without this, switching to Codex (which
+    /// has no data) would hide every other tab including Claude.
     private var allProvidersToday: MenubarPayload {
         store.todayPayload ?? store.payload
     }
@@ -46,16 +46,13 @@ struct AgentTabStrip: View {
         }
     }
 
-    /// Cost for the selected period, not pinned to today. The hero shows payload.current.cost,
-    /// so these tabs must match. Tab VISIBILITY is still driven by todayPayload (via
-    /// visibleFilters) so that tabs don't disappear when switching periods.
     private func cost(for filter: ProviderFilter) -> Double? {
         switch filter {
         case .all:
-            return store.payload.current.cost
+            return allProvidersToday.current.cost
         default:
             let key = filter.rawValue.lowercased()
-            return store.payload.current.providers[key]
+            return allProvidersToday.current.providers[key]
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -25,9 +25,9 @@ struct AgentTabStrip: View {`
`25`	`25`	`}`
`26`	`26`	`}`
`27`	`27`
`28`		`- /// Drive tab VISIBILITY from the all-provider today payload so tabs don't disappear`
`29`		`- /// when switching periods or to a provider with no data. Cost values come from`
`30`		`- /// store.payload (the selected period) via cost(for:).`
	`28`	`+ /// Drive tab visibility and per-tab cost labels from the all-provider payload (today),`
	`29`	`+ /// not the currently selected provider's payload. Without this, switching to Codex (which`
	`30`	`+ /// has no data) would hide every other tab including Claude.`
`31`	`31`	`private var allProvidersToday: MenubarPayload {`
`32`	`32`	`store.todayPayload ?? store.payload`
`33`	`33`	`}`
`@@ -46,16 +46,13 @@ struct AgentTabStrip: View {`
`46`	`46`	`}`
`47`	`47`	`}`
`48`	`48`
`49`		`- /// Cost for the selected period, not pinned to today. The hero shows payload.current.cost,`
`50`		`- /// so these tabs must match. Tab VISIBILITY is still driven by todayPayload (via`
`51`		`- /// visibleFilters) so that tabs don't disappear when switching periods.`
`52`	`49`	`private func cost(for filter: ProviderFilter) -> Double? {`
`53`	`50`	`switch filter {`
`54`	`51`	`case .all:`
`55`		`- return store.payload.current.cost`
	`52`	`+ return allProvidersToday.current.cost`
`56`	`53`	`default:`
`57`	`54`	`let key = filter.rawValue.lowercased()`
`58`		`- return store.payload.current.providers[key]`
	`55`	`+ return allProvidersToday.current.providers[key]`
`59`	`56`	`}`
`60`	`57`	`}`
`61`	`58`	`}`