Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 48b61e2

Browse files
ahmetbibiahmetbibi
committed
week3 homework
1 parent aa6dc33 commit 48b61e2

File tree

4 files changed

+20
-19
lines changed

4 files changed

+20
-19
lines changed

‎homework/App.js

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,19 @@ class App {
1313
*/
1414
async initialize(url) {
1515
const root = document.getElementById('root');
16-
const header = Util.createAndAppend('div', root, { id: 'header' });
17-
Util.createAndAppend('img', header, { src: './hyf.png', alt: 'HackYourFuture logo' });
16+
const header = Util.createAndAppend('header', root, { id: 'header' });
17+
const figure = Util.createAndAppend('figure', header, {
18+
src: './hyf.png',
19+
alt: 'HackYourFuture logo',
20+
});
21+
Util.createAndAppend('img', figure, { src: './hyf.png', alt: 'HackYourFuture logo' });
1822
Util.createAndAppend('h1', header, { text: 'HackYourFuture Github Repositories' });
19-
const choice = Util.createAndAppend('div', root, { id: 'choice' });
23+
const choice = Util.createAndAppend('section', root, { id: 'choice' });
2024
Util.createAndAppend('h3', choice, { text: 'Please Select a Repository Below' });
21-
const selection = Util.createAndAppend('div', choice, { id: 'selection' });
25+
const selection = Util.createAndAppend('section', choice, { id: 'selection' });
2226
Util.createAndAppend('p', selection, { text: 'HYF Repositories: ' });
2327
const opt = Util.createAndAppend('select', selection, { id: 'select' });
24-
Util.createAndAppend('div', root, { id: 'content' });
28+
Util.createAndAppend('section', root, { id: 'content' });
2529
try {
2630
const repositories = await Util.fetchJSON(url);
2731
this.repository = repositories.map(repository => new Repository(repository));
@@ -60,10 +64,10 @@ class App {
6064
const contributors = await repositories.fetchContributors();
6165
const container = document.getElementById('content');
6266
App.clearContainer(container);
63-
const leftDiv = Util.createAndAppend('div', container, { id: 'left-side' });
64-
const rightDiv = Util.createAndAppend('div', container, { id: 'right-side' });
67+
const leftDiv = Util.createAndAppend('article', container, { id: 'left-side' });
68+
const rightDiv = Util.createAndAppend('article', container, { id: 'right-side' });
6569
Util.createAndAppend('h3', rightDiv, { text: 'Contributors' });
66-
const contributorList = Util.createAndAppend('div', rightDiv);
70+
const contributorList = Util.createAndAppend('article', rightDiv);
6771
repositories.render(leftDiv);
6872
contributors
6973
.map(contributor => new Contributor(contributor))
@@ -79,10 +83,7 @@ class App {
7983
*/
8084
renderError(error) {
8185
const root = document.getElementById('root');
82-
Util.createAndAppend('div', root, {
83-
text: error.message,
84-
class: 'alert-error',
85-
});
86+
Util.createAndAppend('section', root, { text: error.message, class: 'alert-error' });
8687
}
8788
}
8889

‎homework/Contributor.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,15 @@ class Contributor {
1313
* @param {HTMLElement} container The container element in which to render the contributor.
1414
*/
1515
render(container) {
16-
const contributorsInfo = Util.createAndAppend('div', container, { class: 'cont-info' });
17-
const contributorsInfoLeft = Util.createAndAppend('div', contributorsInfo, {
16+
const contributorsInfo = Util.createAndAppend('section', container, { class: 'cont-info' });
17+
const contributorsInfoLeft = Util.createAndAppend('article', contributorsInfo, {
1818
class: 'cont-info-left',
1919
});
20-
const contributorsInfoRight = Util.createAndAppend('div', contributorsInfo, {
20+
const contributorsInfoRight = Util.createAndAppend('article', contributorsInfo, {
2121
class: 'cont-info-right',
2222
});
23-
Util.createAndAppend('img', contributorsInfoLeft, {
23+
const contributorImage = Util.createAndAppend('figure', contributorsInfoLeft, {});
24+
Util.createAndAppend('img', contributorImage, {
2425
src: `${this.contributor.avatar_url}`,
2526
alt: `${this.contributor.login} avatar`,
2627
});

‎homework/Repository.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@ class Repository {
1313
* @param {HTMLElement} container The container element in which to render the repository.
1414
*/
1515
render(container) {
16-
const repositoriesSide = Util.createAndAppend('div', container, { id: 'left-side' });
17-
const repositoriesSideContent = Util.createAndAppend('div', repositoriesSide, {
16+
const repositoriesSideContent = Util.createAndAppend('article', container, {
1817
id: 'left-side-content',
1918
});
2019
const table = Util.createAndAppend('table', repositoriesSideContent, {});

‎homework/index2.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
</head>
1919

2020
<body>
21-
<div id="root"></div>
21+
<main id="root"></main>
2222
<script src="./Util.js"></script>
2323
<script src="./Repository.js"></script>
2424
<script src="./Contributor.js"></script>

0 commit comments

Comments
 (0)