Simple attempt at non-scaling points

rreusser · rreusser · commit 429c6fd4e035 · 2016-07-20T22:24:20.000-04:00
diff --git a/src/lib/index.js b/src/lib/index.js
@@ -484,6 +484,27 @@ lib.setScale = function(element, x, y) {
     return transform;
 };
 
+lib.setPointScale = function(selection, x, y) {
+    x = x || 1;
+    y = y || 1;
+
+    // The same scale transform for every point:
+    var scale = ' scale(' + x + ',' + y + ')';
+
+    // A regex to strip any existing scale:
+    var re = /sc.*/;
+
+    selection.each(function(p) {
+        // Get the transform:
+        var t = this.getAttribute('transform').replace(re,'');
+
+        // Append the scale transform
+        this.setAttribute('transform', t + scale);
+    });
+
+    return scale;
+};
+
 lib.isIE = function() {
     return typeof window.navigator.msSaveBlob !== 'undefined';
 };
diff --git a/src/plots/cartesian/dragbox.js b/src/plots/cartesian/dragbox.js
@@ -633,7 +633,10 @@ module.exports = function dragBox(gd, plotinfo, x, y, w, h, ns, ew) {
 
             subplot.plot
                 .call(Lib.setTranslate, plotDx, plotDy)
-                .call(Lib.setScale, xScaleFactor, yScaleFactor);
+                .call(Lib.setScale, xScaleFactor, yScaleFactor)
+                .selectAll('.points').selectAll('.point')
+                    .call(Lib.setPointScale, 1 / xScaleFactor, 1 / yScaleFactor);
+
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -633,7 +633,10 @@ module.exports = function dragBox(gd, plotinfo, x, y, w, h, ns, ew) {`
`633`	`633`
`634`	`634`	`subplot.plot`
`635`	`635`	`.call(Lib.setTranslate, plotDx, plotDy)`
`636`		`- .call(Lib.setScale, xScaleFactor, yScaleFactor);`
	`636`	`+ .call(Lib.setScale, xScaleFactor, yScaleFactor)`
	`637`	`+ .selectAll('.points').selectAll('.point')`
	`638`	`+ .call(Lib.setPointScale, 1 / xScaleFactor, 1 / yScaleFactor);`
	`639`	`+`
`637`	`640`	`}`
`638`	`641`	`}`
`639`	`642`