feat: decode::Options::default_from_object_hash()

Byron · Byron · commit 9e03110578bd · 2022-10-12T15:42:48.000+08:00
An easier way to initialize decode options, providing only the mandatory
information.
diff --git a/git-index/src/decode/mod.rs b/git-index/src/decode/mod.rs
@@ -45,6 +45,17 @@ pub struct Options {
     pub min_extension_block_in_bytes_for_threading: usize,
 }
 
+impl Options {
+    /// Produce a reasonable default set of options knowing only the kind of object hash to expect.
+    pub fn default_from_object_hash(object_hash: git_hash::Kind) -> Self {
+        Options {
+            object_hash,
+            thread_limit: None,
+            min_extension_block_in_bytes_for_threading: 0,
+        }
+    }
+}
+
 impl State {
     /// Decode an index state from `data` and store `timestamp` in the resulting instance for pass-through.
     pub fn from_bytes(
diff --git a/git-index/tests/index/mod.rs b/git-index/tests/index/mod.rs
@@ -23,11 +23,7 @@ fn size_of_entry() {
 }
 
 pub fn decode_options() -> git_index::decode::Options {
-    git_index::decode::Options {
-        object_hash: git_hash::Kind::Sha1,
-        thread_limit: None,
-        min_extension_block_in_bytes_for_threading: 0,
-    }
+    git_index::decode::Options::default_from_object_hash(git_hash::Kind::Sha1)
 }
 
 enum Fixture {

Original file line number	Diff line number	Diff line change
`@@ -23,11 +23,7 @@ fn size_of_entry() {`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`pub fn decode_options() -> git_index::decode::Options {`
`26`		`- git_index::decode::Options {`
`27`		`- object_hash: git_hash::Kind::Sha1,`
`28`		`- thread_limit: None,`
`29`		`- min_extension_block_in_bytes_for_threading: 0,`
`30`		`- }`
	`26`	`+ git_index::decode::Options::default_from_object_hash(git_hash::Kind::Sha1)`
`31`	`27`	`}`
`32`	`28`
`33`	`29`	`enum Fixture {`