Change type of Payload.size from Optional[float] to Optional[int]#3484
Merged
Conversation
Contributor
asvetlov
approved these changes
Jan 4, 2019
Member
asvetlov
left a comment
There was a problem hiding this comment.
Sorry, adding types was a very massive change.
If int works -- let's apply the change.
Codecov Report
@@ Coverage Diff @@
## master #3484 +/- ##
=======================================
Coverage 97.92% 97.92%
=======================================
Files 44 44
Lines 8567 8567
Branches 1383 1383
=======================================
Hits 8389 8389
Misses 74 74
Partials 104 104
Continue to review full report at Codecov.
|
asvetlov
pushed a commit
that referenced
this pull request
Jan 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This changes type of
Payload.sizeproperty fromfloattoint. Since this property defines amount of bytes which payload contains, it's impossible to have there floating point value.This behavior was introduced in #3294.
Are there changes in behavior for the user?
It's possible to break some annotations for users custom Payload instances, but no runtime issues should be caused.