Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Release all forgotten resources in tests#5494

Merged
webknjaz merged 4 commits into
masterfrom
bugfixes/release-resources-pytest
Feb 24, 2021
Merged

Release all forgotten resources in tests#5494
webknjaz merged 4 commits into
masterfrom
bugfixes/release-resources-pytest

Conversation

@webknjaz
Copy link
Copy Markdown
Member

@webknjaz webknjaz commented Feb 24, 2021 •
edited
Loading

What do these changes do?

Ever since pytest got updated to v6.2, it started emitting resource
warnings under new Pythons 3.8+ which results in a failed status.

This change addresses this issue by properly most of the resources
so they don't even appear and ignoring the rest in cases of race
conditions and other cases that are hard to track down.

Are there changes in behavior for the user?

No.

Related issue number

N/A

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@webknjaz webknjaz self-assigned this Feb 24, 2021
@webknjaz webknjaz requested a review from asvetlov as a code owner February 24, 2021 10:28
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 24, 2021 •
edited
Loading

Codecov Report

Merging #5494 (41d7662) into master (1ec360f) will increase coverage by 0.55%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5494      +/-   ##
==========================================
+ Coverage   96.61%   97.17%   +0.55%     
==========================================
  Files          41       41              
  Lines        8815     8857      +42     
  Branches     1412     1424      +12     
==========================================
+ Hits         8517     8607      +90     
+ Misses        167      133      -34     
+ Partials      131      117      -14
Flag Coverage Δ
unit 97.06% <100.00%> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/web_request.py 95.99% <100.00%> (+0.52%) ⬆️
aiohttp/tracing.py 100.00% <0.00%> (ø)
aiohttp/cookiejar.py 98.78% <0.00%> (+<0.01%) ⬆️
aiohttp/web_response.py 98.21% <0.00%> (+0.22%) ⬆️
aiohttp/client_reqrep.py 97.86% <0.00%> (+0.34%) ⬆️
aiohttp/helpers.py 96.77% <0.00%> (+0.45%) ⬆️
aiohttp/web_protocol.py 86.41% <0.00%> (+0.90%) ⬆️
aiohttp/web.py 99.14% <0.00%> (+1.70%) ⬆️
aiohttp/test_utils.py 99.68% <0.00%> (+1.86%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ec360f...3c5aa75. Read the comment docs.

@psf-chronographer psf-chronographer Bot added the bot:chronographer:provided There is a change note present in this PR label Feb 24, 2021
@webknjaz webknjaz merged commit 8c82ba1 into master Feb 24, 2021
@webknjaz webknjaz deleted the bugfixes/release-resources-pytest branch February 24, 2021 11:27
webknjaz added a commit that referenced this pull request Feb 25, 2021
@webknjaz
Merge branch 'bugfixes/release-resources-pytest'
0249bd5 
This change makes sure to release most of the hanging resources
in the lib and tests. They were detected by pytest v6.2+.

PR #5494

(cherry picked from commit 8c82ba1)
webknjaz added a commit that referenced this pull request Feb 25, 2021
@webknjaz
Merge branch 'bugfixes/release-resources-pytest'
33db6e7 
This change makes sure to release most of the hanging resources
in the lib and tests. They were detected by pytest v6.2+.

PR #5494

(cherry picked from commit 8c82ba1)
webknjaz added a commit that referenced this pull request Feb 25, 2021
@webknjaz
Merge branch 'bugfixes/release-resources-pytest'
ea66280 
This change makes sure to release most of the hanging resources
in the lib and tests. They were detected by pytest v6.2+.

PR #5494

(cherry picked from commit 8c82ba1)
(cherry picked from commit 33db6e7)
webknjaz added a commit that referenced this pull request Feb 25, 2021
@webknjaz
Merge branch 'bugfixes/release-resources-pytest'
38e3290 
This change makes sure to release most of the hanging resources
in the lib and tests. They were detected by pytest v6.2+.

PR #5494

(cherry picked from commit 8c82ba1)
webknjaz added a commit that referenced this pull request Feb 25, 2021
@webknjaz
Merge branch 'bugfixes/release-resources-pytest'
5c87c6a 
This change makes sure to release most of the hanging resources
in the lib and tests. They were detected by pytest v6.2+.

PR #5494

(cherry picked from commit 8c82ba1)
webknjaz added a commit that referenced this pull request Feb 25, 2021
@webknjaz
Merge branch 'bugfixes/release-resources-pytest'
06a4149 
This change makes sure to release most of the hanging resources
in the lib and tests. They were detected by pytest v6.2+.

PR #5494

(cherry picked from commit 8c82ba1)
webknjaz added a commit that referenced this pull request Feb 25, 2021
@webknjaz
Merge branch 'bugfixes/release-resources-pytest'
fe5e684 
This change makes sure to release most of the hanging resources
in the lib and tests. They were detected by pytest v6.2+.

PR #5494

(cherry picked from commit 8c82ba1)
@patchback
Copy link
Copy Markdown
Contributor

patchback Bot commented Apr 18, 2021 •
edited
Loading

Backport to 3.8: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 8c82ba1 on top of patchback/backports/3.8/8c82ba11b9e38851d75476d261a1442402cc7592/pr-5494

Backporting merged PR #5494 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it: 
    $ git add remote upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code: 
    $ git fetch upstream
$ git checkout -b patchback/backports/3.8/8c82ba11b9e38851d75476d261a1442402cc7592/pr-5494 upstream/3.8
  4. Now, cherry-pick PR Release all forgotten resources in tests #5494 contents into that branch: 
    $ git cherry-pick -x 8c82ba11b9e38851d75476d261a1442402cc7592
    If it'll yell at you with something like fatal: Commit 8c82ba11b9e38851d75476d261a1442402cc7592 is a merge but no -m option was given., add -m 1 as follows intead: 
    $ git cherry-pick -m1 -x 8c82ba11b9e38851d75476d261a1442402cc7592
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Release all forgotten resources in tests #5494 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub: 
    $ git push origin patchback/backports/3.8/8c82ba11b9e38851d75476d261a1442402cc7592/pr-5494
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@webknjaz webknjaz mentioned this pull request Apr 18, 2021
Closed
commonism pushed a commit to commonism/aiohttp that referenced this pull request Apr 27, 2021
@webknjaz @commonism
Add change fragments for PR aio-libs#5494
e2ec3a2
commonism pushed a commit to commonism/aiohttp that referenced this pull request Apr 27, 2021
@webknjaz @commonism
Add change fragments for PR aio-libs#5494
bd4fa74
webknjaz added a commit to webknjaz/aiohttp that referenced this pull request Oct 18, 2021
@webknjaz
Merge branch 'bugfixes/release-resources-pytest'
974e5cb 
This change makes sure to release most of the hanging resources
in the lib and tests. They were detected by pytest v6.2+.

PR aio-libs#5494

(cherry picked from commit 8c82ba1)
webknjaz added a commit to webknjaz/aiohttp that referenced this pull request Oct 18, 2021
@webknjaz
Merge branch 'bugfixes/release-resources-pytest'
44ba590 
This change makes sure to release most of the hanging resources
in the lib and tests. They were detected by pytest v6.2+.

PR aio-libs#5494

(cherry picked from commit 8c82ba1)
webknjaz added a commit to webknjaz/aiohttp that referenced this pull request Oct 18, 2021
@webknjaz
Merge branch 'bugfixes/release-resources-pytest'
8a4b356 
This change makes sure to release most of the hanging resources
in the lib and tests. They were detected by pytest v6.2+.

PR aio-libs#5494

(cherry picked from commit 8c82ba1)
webknjaz added a commit to webknjaz/aiohttp that referenced this pull request Oct 18, 2021
@webknjaz
Merge branch 'bugfixes/release-resources-pytest'
0977166 
This change makes sure to release most of the hanging resources
in the lib and tests. They were detected by pytest v6.2+.

PR aio-libs#5494

(cherry picked from commit 8c82ba1)
webknjaz added a commit to webknjaz/aiohttp that referenced this pull request Oct 18, 2021
@webknjaz
Merge branch 'bugfixes/release-resources-pytest'
a86fb67 
This change makes sure to release most of the hanging resources
in the lib and tests. They were detected by pytest v6.2+.

PR aio-libs#5494

(cherry picked from commit 8c82ba1)
webknjaz added a commit to webknjaz/aiohttp that referenced this pull request Oct 19, 2021
@webknjaz
Merge branch 'bugfixes/release-resources-pytest'
858e46e 
This change makes sure to release most of the hanging resources
in the lib and tests. They were detected by pytest v6.2+.

PR aio-libs#5494

(cherry picked from commit 8c82ba1)
webknjaz added a commit to webknjaz/aiohttp that referenced this pull request Oct 19, 2021
@webknjaz
Merge branch 'bugfixes/release-resources-pytest'
f25b43c 
This change makes sure to release most of the hanging resources
in the lib and tests. They were detected by pytest v6.2+.

PR aio-libs#5494

(cherry picked from commit 8c82ba1)
webknjaz added a commit to webknjaz/aiohttp that referenced this pull request Oct 19, 2021
@webknjaz
Merge branch 'bugfixes/release-resources-pytest'
880eabc 
This change makes sure to release most of the hanging resources
in the lib and tests. They were detected by pytest v6.2+.

PR aio-libs#5494

(cherry picked from commit 8c82ba1)
webknjaz added a commit to webknjaz/aiohttp that referenced this pull request Oct 19, 2021
@webknjaz
Merge branch 'bugfixes/release-resources-pytest'
45a43ba 
This change makes sure to release most of the hanging resources
in the lib and tests. They were detected by pytest v6.2+.

PR aio-libs#5494

(cherry picked from commit 8c82ba1)
webknjaz added a commit to webknjaz/aiohttp that referenced this pull request Oct 19, 2021
@webknjaz
Merge branch 'bugfixes/release-resources-pytest'
11e1b14 
This change makes sure to release most of the hanging resources
in the lib and tests. They were detected by pytest v6.2+.

PR aio-libs#5494

(cherry picked from commit 8c82ba1)
@webknjaz webknjaz mentioned this pull request Oct 19, 2021
Merged
webknjaz added a commit that referenced this pull request Oct 19, 2021
@webknjaz
[backport][3.8] Release hanging resources in tests (#6104)
998c347 
This change makes sure to release most of the hanging resources
in the lib and tests. They were detected by pytest v6.2+.

PR #5494

(cherry picked from commit 8c82ba1)
@Dreamsorcerer Dreamsorcerer mentioned this pull request Aug 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

@webknjaz webknjaz

Labels

bot:chronographer:provided There is a change note present in this PR bug infra

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@webknjaz