Conversation
|
@webknjaz Any idea why the chronographer didn't catch CHANGES files? |
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #6139 +/- ##
==========================================
- Coverage 93.32% 93.32% -0.01%
==========================================
Files 102 102
Lines 30140 30166 +26
Branches 2696 2699 +3
==========================================
+ Hits 28129 28151 +22
- Misses 1837 1840 +3
- Partials 174 175 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Because you named them wrong. The number should go after the type. By the way, we now have a Sphinx integration that also shows unreleased change notes. See https://aiohttp--6139.org.readthedocs.build/en/6139/changes.html#to-be-included-in-vrelease-if-present. Look closer and you'll see that your names confused Towncrier and it linked issues #1 and #2 to your change notes and not #6139. |
|
Aha, thanks! |
Backport to 3.8: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 00d5286 on top of patchback/backports/3.8/00d52864eeea43d18ad022c7cb0e80d9741e32b9/pr-6139 Backporting merged PR #6139 into master
🤖 @patchback |
💔 Backport was not successfulThe PR was attempted backported to the following branches:
|
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
|
Backported by d8efd32 |
No description provided.