Add extend_query method #1128
Merged
Add extend_query method #1128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1128 +/- ##
==========================================
+ Coverage 95.15% 95.20% +0.04%
==========================================
Files 30 30
Lines 4646 4709 +63
Branches 411 417 +6
==========================================
+ Hits 4421 4483 +62
- Misses 199 200 +1
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Verified this works as expected in diff --git a/aiohttp/client_reqrep.py b/aiohttp/client_reqrep.py
index 6eaba561b..6e0f76a2e 100644
--- a/aiohttp/client_reqrep.py
+++ b/aiohttp/client_reqrep.py
@@ -229,10 +229,7 @@ class ClientRequest:
# assert session is not None
self._session = cast("ClientSession", session)
if params:
- q = MultiDict(url.query)
- url2 = url.with_query(params)
- q.extend(url2.query)
- url = url.with_query(q)
+ url = url.extend_query(params)
self.original_url = url
self.url = url.with_fragment(None)
self.method = method.upper() |
|
Doing a bit of production testing before merge. If that all goes well, I'll bump the version, do a release and than open a PR to aiohttp to replace the hand rolled method |
bdraco
commented
Sep 8, 2024
|
In turns out I didn't need to split update_query so I can split this PR up a bit |
bdraco
commented
Sep 8, 2024
bdraco
commented
Sep 8, 2024
bdraco
added a commit
that referenced
this pull request
Sep 8, 2024
bdraco
commented
Sep 8, 2024
bdraco
commented
Sep 8, 2024
bdraco
commented
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Adds a new method called
extend_querythat will add additional keys instead of replacing them likeupdate_query. The goal is to replace the hand rolled version inaiohttpAre there changes in behavior for the user?
no
Related issue number
#1127