add repositionOnUpdate opts for Axes.drawLabels

etpinard · etpinard · commit cbb3b7d2cc9c · 2018-12-06T18:09:09.000-05:00
- as x/y label text position can change on drag
- test to come
diff --git a/src/plots/cartesian/axes.js b/src/plots/cartesian/axes.js
@@ -1756,6 +1756,7 @@ axes.drawOne = function(gd, ax, opts) {
                 vals: getSecondaryLabelVals(ax, vals),
                 layer: mainAxLayer,
                 cls: axId + 'tick2',
+                repositionOnUpdate: true,
                 transFn: transFn,
                 labelXFn: secondaryLabelFns.labelXFn,
                 labelYFn: secondaryLabelFns.labelYFn,
@@ -2283,6 +2284,7 @@ axes.drawZeroLine = function(gd, ax, opts) {
  * - {array of object} vals (calcTicks output-like)
  * - {d3 selection} layer
  * - {string (optional)} cls (node className)
+ * - {boolean} repositionOnUpdate (set to true to reposition update selection)
  * - {fn} transFn
  * - {fn} labelXFn
  * - {fn} labelYFn
@@ -2336,8 +2338,7 @@ axes.drawLabels = function(gd, ax, opts) {
 
     tickLabels.exit().remove();
 
-    // TODO ??
-    if(isAngular(ax)) {
+    if(opts.repositionOnUpdate) {
         tickLabels.each(function(d) {
             d3.select(this).select('text')
                 .call(svgTextUtils.positionText, labelXFn(d), labelYFn(d));
diff --git a/src/plots/polar/polar.js b/src/plots/polar/polar.js
@@ -643,6 +643,7 @@ proto.updateAngularAxis = function(fullLayout, polarLayout) {
         Axes.drawLabels(gd, ax, {
             vals: vals,
             layer: layers['angular-axis'],
+            repositionOnUpdate: true,
             transFn: transFn,
             labelXFn: labelXFn,
             labelYFn: labelYFn,
