alexwebmaster
diff --git a/‎.travis.yml
Lines changed: 1 addition & 8 deletions b/‎.travis.yml
Lines changed: 1 addition & 8 deletions
diff --git a/‎Behavioral/Iterator/Book.php
Lines changed: 10 additions & 4 deletions b/‎Behavioral/Iterator/Book.php
Lines changed: 10 additions & 4 deletions
diff --git a/‎Behavioral/Iterator/BookList.php
Lines changed: 37 additions & 10 deletions b/‎Behavioral/Iterator/BookList.php
Lines changed: 37 additions & 10 deletions
diff --git a/‎Behavioral/Iterator/BookListIterator.php
Lines changed: 0 additions & 86 deletions b/‎Behavioral/Iterator/BookListIterator.php
Lines changed: 0 additions & 86 deletions
diff --git a/‎Behavioral/Iterator/BookListReverseIterator.php
Lines changed: 0 additions & 87 deletions b/‎Behavioral/Iterator/BookListReverseIterator.php
Lines changed: 0 additions & 87 deletions
diff --git a/‎Behavioral/Iterator/README.rst
Lines changed: 2 additions & 15 deletions b/‎Behavioral/Iterator/README.rst
Lines changed: 2 additions & 15 deletions
@@ -3,17 +3,10 @@ language: php
 sudo: false
 
 php:
-  - 5.3
-  - 5.4
-  - 5.5
-  - 5.6
   - 7.0
-  - hhvm
+  - 7.1
 
 matrix:
-  allow_failures:
-    - php: hhvm
-    - php: 7.0
   fast_finish: true
 
 cache:
 
@@ -4,27 +4,33 @@
 
 class Book
 {
+    /**
+     * @var string
+     */
     private $author;
 
+    /**
+     * @var string
+     */
     private $title;
 
-    public function __construct($title, $author)
+    public function __construct(string $title, string $author)
     {
         $this->author = $author;
         $this->title = $title;
     }
 
-    public function getAuthor()
+    public function getAuthor(): string
     {
         return $this->author;
     }
 
-    public function getTitle()
+    public function getTitle(): string
     {
         return $this->title;
     }
 
-    public function getAuthorAndTitle()
+    public function getAuthorAndTitle(): string
     {
         return $this->getTitle().' by '.$this->getAuthor();
     }
 
@@ -2,16 +2,17 @@
 
 namespace DesignPatterns\Behavioral\Iterator;
 
-class BookList implements \Countable
+class BookList implements \Countable, \Iterator
 {
-    private $books;
+    /**
+     * @var Book[]
+     */
+    private $books = [];
 
-    public function getBook($bookNumberToGet)
-    {
-        if (isset($this->books[$bookNumberToGet])) {
-            return $this->books[$bookNumberToGet];
-        }
-    }
+    /**
+     * @var int
+     */
+    private $currentIndex = 0;
 
     public function addBook(Book $book)
     {
@@ -21,15 +22,41 @@ public function addBook(Book $book)
     public function removeBook(Book $bookToRemove)
     {
         foreach ($this->books as $key => $book) {
-            /** @var Book $book */
             if ($book->getAuthorAndTitle() === $bookToRemove->getAuthorAndTitle()) {
                 unset($this->books[$key]);
             }
         }
+
+        $this->books = array_values($this->books);
     }
 
-    public function count()
+    public function count(): int
     {
         return count($this->books);
     }
+
+    public function current(): Book
+    {
+        return $this->books[$this->currentIndex];
+    }
+
+    public function key(): int
+    {
+        return $this->currentIndex;
+    }
+
+    public function next()
+    {
+        $this->currentIndex++;
+    }
+
+    public function rewind()
+    {
+        $this->currentIndex = 0;
+    }
+
+    public function valid(): bool
+    {
+        return isset($this->books[$this->currentIndex]);
+    }
 }
@@ -4,8 +4,7 @@
 Purpose
 -------
 
-To make an object iterable and to make it appear like a collection of
-objects.
+To make an object iterable and to make it appear like a collection of objects.
 
 Examples
 --------
@@ -45,18 +44,6 @@ BookList.php
    :language: php
    :linenos:
 
-BookListIterator.php
-
-.. literalinclude:: BookListIterator.php
-   :language: php
-   :linenos:
-
-BookListReverseIterator.php
-
-.. literalinclude:: BookListReverseIterator.php
-   :language: php
-   :linenos:
-
 Test
 ----
 
@@ -67,4 +54,4 @@ Tests/IteratorTest.php
    :linenos:
 
 .. _`GitHub`: https://github.com/domnikl/DesignPatternsPHP/tree/master/Behavioral/Iterator
-.. __: http://en.wikipedia.org/wiki/Iterator_pattern
+.. __: http://en.wikipedia.org/wiki/Iterator_pattern
Original file line number	Diff line number	Diff line change
`@@ -4,27 +4,33 @@`
`4`	`4`
`5`	`5`	`class Book`
`6`	`6`	`{`
	`7`	`+ /**`
	`8`	`+ * @var string`
	`9`	`+ */`
`7`	`10`	`private $author;`
`8`	`11`
	`12`	`+ /**`
	`13`	`+ * @var string`
	`14`	`+ */`
`9`	`15`	`private $title;`
`10`	`16`
`11`		`- public function __construct($title, $author)`
	`17`	`+ public function __construct(string $title, string $author)`
`12`	`18`	`{`
`13`	`19`	`$this->author = $author;`
`14`	`20`	`$this->title = $title;`
`15`	`21`	`}`
`16`	`22`
`17`		`- public function getAuthor()`
	`23`	`+ public function getAuthor(): string`
`18`	`24`	`{`
`19`	`25`	`return $this->author;`
`20`	`26`	`}`
`21`	`27`
`22`		`- public function getTitle()`
	`28`	`+ public function getTitle(): string`
`23`	`29`	`{`
`24`	`30`	`return $this->title;`
`25`	`31`	`}`
`26`	`32`
`27`		`- public function getAuthorAndTitle()`
	`33`	`+ public function getAuthorAndTitle(): string`
`28`	`34`	`{`
`29`	`35`	`return $this->getTitle().' by '.$this->getAuthor();`
`30`	`36`	`}`