Load limits from /common/config

64json · 64json · commit 3ac076d28179 · 2018-11-12T14:15:00.000-05:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+## [2.0.4]
+### Fixed
+- Load limits from /common/config
+
 ## [2.0.3]
 ### Fixed
 - Handle unhandled promise rejections
@@ -26,4 +30,4 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Tracers for Java and C++.
 
 ### Changed
-- Almost every method has been changed. Take a look at [Tracer API](https://github.com/algorithm-visualizer/tracers/wiki).
+- Almost every method has been changed. Take a look at [Tracer API](https://github.com/algorithm-visualizer/tracers/wiki).
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@algorithm-visualizer/tracer-generator",
-  "version": "2.0.3",
+  "version": "2.0.4",
   "description": "Visualization Libraries for Algorithm Visualizer",
   "scripts": {
     "build": "node ./node_modules/webpack/bin/webpack --bail --progress --config webpack.config.js && chmod +x ./bin/*"
diff --git a/src/common/config.js b/src/common/config.js
@@ -1 +1,7 @@
-export {};
+const maxTraces = 1e6;
+const maxTracers = 1e2;
+
+export {
+  maxTraces,
+  maxTracers,
+};
diff --git a/src/languages/Exeuter.js b/src/languages/Exeuter.js
@@ -1,5 +1,6 @@
 import { execute } from '/common/util';
 import Commander from '/languages/Commander';
+import { maxTracers, maxTraces } from '/common/config';
 
 class Executer extends Commander {
   constructor({ name, compileCommand, runCommand }) {
@@ -17,7 +18,7 @@ class Executer extends Commander {
       '-w=/usr/judge',
       `-v=$PWD/tracers:/usr/bin/tracers:ro`,
       `-v=${tempPath}:/usr/judge:rw`,
-      `-e MAX_TRACES=${1e6} -e MAX_TRACERS=${1e2}`, // TODO: load from /common/config
+      `-e MAX_TRACES=${maxTraces} -e MAX_TRACERS=${maxTracers}`,
       this.executerImageTag,
       '/bin/bash -c',
       `"${command}"`,
diff --git a/src/languages/js/tracers/src/Tracer.js b/src/languages/js/tracers/src/Tracer.js
@@ -1,5 +1,4 @@
-const MAX_TRACES = 1e6;
-const MAX_TRACERS = 1e2;
+import { maxTraces, maxTracers } from '../../../../common/config';
 
 class Tracer {
   static addTracer(className, title) {
@@ -17,8 +16,8 @@ class Tracer {
       args: JSON.parse(JSON.stringify(args)),
     };
     this.traces.push(trace);
-    if (this.traces.length > MAX_TRACES) throw new Error('Traces Limit Exceeded');
-    if (this.tracerCount > MAX_TRACERS) throw new Error('Tracers Limit Exceeded');
+    if (this.traces.length > maxTraces) throw new Error('Traces Limit Exceeded');
+    if (this.tracerCount > maxTracers) throw new Error('Tracers Limit Exceeded');
   }
 
   constructor(title = this.constructor.name) {

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@algorithm-visualizer/tracer-generator",`
`3`		`- "version": "2.0.3",`
	`3`	`+ "version": "2.0.4",`
`4`	`4`	`"description": "Visualization Libraries for Algorithm Visualizer",`
`5`	`5`	`"scripts": {`
`6`	`6`	`"build": "node ./node_modules/webpack/bin/webpack --bail --progress --config webpack.config.js && chmod +x ./bin/*"`