fix: properly handle CRDs that are type Secret#999
Draft
nicolerenee wants to merge 1 commit into
Draft
Conversation
allenporter
reviewed
Sep 7, 2025
Owner
allenporter
left a comment
There was a problem hiding this comment.
Looks great, thank you. Can you also add tests? This logic is in middle of being rewritten and will change in the future so i wouldn't want it to get accidentally broken.
2f28cb1 to
15511c3
Compare
Author
|
@allenporter I've added some tests that verify that both v1/secrets and CRD secrets are properly handled. Let me know if you want any changes to them or anything. |
allenporter
requested changes
Sep 12, 2025
|
|
||
| async def test_secret_crd_filtering() -> None: | ||
| """Test that CRDs with kind Secret but non-v1 apiVersion are not parsed as Secret objects.""" | ||
| from flux_local.manifest import Kustomization, Secret, ConfigMap |
Owner
There was a problem hiding this comment.
Put imports at the top of the file, not inlined in tehe test.
(I'm assuming this is ai generated)
| assert await get_hr() == [] | ||
|
|
||
|
|
||
| async def test_secret_crd_filtering() -> None: |
Owner
There was a problem hiding this comment.
This test is not testing crd filtering in the library, Its exercising code within the test only. This needs to actually call the real code, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working with CRDs that have a type of
Secretflux-local fails to build kustomizations. Currently the code assumes anything that is a Secret will be a member of the v1 api group, this instead adds a check to only treat things as a secret if they are in v1.