-
|
The Allmaps maplibre plugin does not work for me with the latest version of maplibre (5.6.1). The plugin seems to have been created for a previous major version of maplibre (4.5.0). Is there a version of the plugin compatible with the current version? |
Beta Was this translation helpful? Give feedback.
Replies: 3 comments 21 replies
-
|
Hey Ryan! We're working on a new version that's built for the latest version! Ideally, we would have multiple versions, one for each major version of MapLibre (and OpenLayers and Leaflet), but I haven't found an easy way to do this. On our side, it shouldn't be too complicated, 99% of the code will stay the same, only a few TS types are different. The complexity lies in creating a JS package that has multiple exports, each built for a different version of MapLibre. It should work something like this: import { WarpedMapLayer } from '@allmaps/maplibre/5'This is probably possible, need to look into it more! |
Beta Was this translation helpful? Give feedback.
-
|
Is there anything I can assist with, or possible temporary workarounds for getting the plugin to work with Maplibre 5? Working on a fork, I can fix most of the typing issues, but I get errors that seem to be related to web workers: |
Beta Was this translation helpful? Give feedback.
-
|
Yeah this is the issue I'm trying to solve! We recently started using Web Workers for some image processing tasks, all of this works fine in the SvelteKit apps, but when bundling with Vite and publishing to npm, this error occurs. Probably easy to fix, but I don't know how to debug and test this locally this without publishing each step of my debugging process to npm. |
Beta Was this translation helpful? Give feedback.
-
|
If you know how I can fix this, let me know! |
Beta Was this translation helpful? Give feedback.
-
|
OK, that is good to know. I am trying to get things working using esbuild—I’ll report back |
Beta Was this translation helpful? Give feedback.
-
|
I tried using So then I just tried using vite, and found that (as you said) this is a general problem with using the In the transpiled JS code of the vite app I can see that the initialization for the Worker is using a script url with the path const worker = new Worker(
new URL(
/* @vite-ignore */
"" + new URL("/node_modules/.vite/assets/fetch-and-get-image-data-BXcOBitk.js", import.meta.url).href,
import.meta.url
)
);… which is promising because in your npm package But vite does not seem to include this worker script in the bundle, or at least it does not serve it via the dev server. When I try to curl I am not familiar enough with vite to know how to force it to include the worker script as an asset in the bundle. Is it supposed to do that automagically? Maybe the odd double invocation of There are a number of Github issues about this (e.g. vitejs/vite#11672 (comment)) but none of them present a conclusive solution. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for your help! I'll try to work on it a bit more today, but don't have much time, I'm going on vacation tomorrow. The only way I have been able to fix issues like this in the past is by just trying all solutions I could think of, publish a new version to npm and then hope it worked. Usually, it didn't. Or it did, and then it stopped working with a new version of vite or some other change. I don't think I'm the only one who is confused about how to best publish ESM packages. You can also try using an older version of the MapLibre plugin, like the one in this notebook: https://observablehq.com/@allmaps/maplibre-plugin, it uses https://cdn.jsdelivr.net/npm/@allmaps/[email protected]/+esm. |
Beta Was this translation helpful? Give feedback.
-
|
I’ll work on it a bit more; I think it is very close to working. Have a good vacation! |
Beta Was this translation helpful? Give feedback.
-
|
I posted a question in the Vite forums. |
Beta Was this translation helpful? Give feedback.
-
|
I read somewhere that maybe vite's |
Beta Was this translation helpful? Give feedback.
-
|
Loading the module from UNPKG also works: import { WarpedMapLayer } from "https://unpkg.com/@allmaps/[email protected]?module" |
Beta Was this translation helpful? Give feedback.
-
|
So, here is what is working for me. I am using Vite. I have installed:
And in my "overrides": {
"@allmaps/render": "1.0.0-beta.73"
}Importing like this: import { WarpedMapLayer } from "@allmaps/maplibre"Before running Let me know if I can help with troubleshooting! |
Beta Was this translation helpful? Give feedback.
-
|
What happens if you use the latest version of @allmaps/maplibre: @allmaps/[email protected]. Will it then work without the |
Beta Was this translation helpful? Give feedback.
-
|
It works, but I get an error related to loading the source map:
Looks like the URL of the source map is getting garbled? |
Beta Was this translation helpful? Give feedback.
-
|
That's strange. In @allmaps/render's However, I can find no references to this file, or any other files that contain the string How does the browser know it should use this file? And why |
Beta Was this translation helpful? Give feedback.
Hey Ryan! We're working on a new version that's built for the latest version! Ideally, we would have multiple versions, one for each major version of MapLibre (and OpenLayers and Leaflet), but I haven't found an easy way to do this. On our side, it shouldn't be too complicated, 99% of the code will stay the same, only a few TS types are different.
The complexity lies in creating a JS package that has multiple exports, each built for a different version of MapLibre. It should work something like this:
This is probably possible, need to look into it more!