make sure scroll clears selection outline not just the 1st time

etpinard · etpinard · commit ffe1700aa3c3 · 2018-05-29T11:16:43.000-04:00
diff --git a/src/plots/cartesian/dragbox.js b/src/plots/cartesian/dragbox.js
@@ -393,9 +393,7 @@ function makeDragBox(gd, plotinfo, x, y, w, h, ns, ew) {
             return;
         }
 
-        if(redrawTimer === null) {
-            clearSelect(zoomlayer);
-        }
+        clearSelect(zoomlayer);
 
         // If a transition is in progress, then disable any behavior:
         if(gd._transitioningWithDuration) {
diff --git a/test/jasmine/tests/select_test.js b/test/jasmine/tests/select_test.js
@@ -539,16 +539,27 @@ describe('@flaky Test select box and lasso in general:', function() {
         mockCopy.layout.dragmode = 'select';
         mockCopy.config = {scrollZoom: true};
 
-        Plotly.plot(gd, mockCopy).then(function() {
+        function _drag() {
             resetEvents(gd);
             drag(selectPath);
             return selectedPromise;
-        })
-        .then(function() {
+        }
+
+        function _scroll() {
             mouseEvent('mousemove', selectPath[0][0], selectPath[0][1]);
             mouseEvent('scroll', selectPath[0][0], selectPath[0][1], {deltaX: 0, deltaY: -20});
+        }
+
+        Plotly.plot(gd, mockCopy)
+        .then(_drag)
+        .then(_scroll)
+        .then(function() {
+            assertSelectionNodes(0, 0);
         })
+        .then(_drag)
+        .then(_scroll)
         .then(function() {
+            // make sure it works the 2nd time aroung
             assertSelectionNodes(0, 0);
         })
         .catch(failTest)

Original file line number	Diff line number	Diff line change
`@@ -393,9 +393,7 @@ function makeDragBox(gd, plotinfo, x, y, w, h, ns, ew) {`
`393`	`393`	`return;`
`394`	`394`	`}`
`395`	`395`
`396`		`- if(redrawTimer === null) {`
`397`		`- clearSelect(zoomlayer);`
`398`		`- }`
	`396`	`+ clearSelect(zoomlayer);`
`399`	`397`
`400`	`398`	`// If a transition is in progress, then disable any behavior:`
`401`	`399`	`if(gd._transitioningWithDuration) {`