Adds entity metadata support.

gmajoulet · gmajoulet · commit a82ec8730287 · 2020-08-03T15:51:59.000-04:00
diff --git a/extensions/amp-story/1.0/test/validator-amp-story.html b/extensions/amp-story/1.0/test/validator-amp-story.html
@@ -29,7 +29,7 @@
   <script async custom-element="amp-story" src="https://cdn.ampproject.org/v0/amp-story-1.0.js"></script>
 </head>
 <body>
-  <amp-story standalone title="My Story" publisher="Me" publisher-logo-src="http://me.com/logo.png" poster-portrait-src="http://me.com/portrait.jpg" poster-square-src="http://me.com/square.jpg" poster-landscape-src="http://me.com/landscape.jpg" background-audio="http://me.com/path/to/my.mp3">
+  <amp-story standalone title="My Story" publisher="Me" publisher-logo-src="http://me.com/logo.png" poster-portrait-src="http://me.com/portrait.jpg" poster-square-src="http://me.com/square.jpg" poster-landscape-src="http://me.com/landscape.jpg" background-audio="http://me.com/path/to/my.mp3" entity="Someone else" entity-logo-src="http://someoneelse.com/logo.png" entity-url="http://someoneelse.com/profile">
     <amp-story-page id="1" background-audio="path/to/my.mp3" auto-advance-after="any-value">
       <amp-story-grid-layer template="horizontal">
         <h5 animate-in="drop">
diff --git a/extensions/amp-story/1.0/test/validator-amp-story.out b/extensions/amp-story/1.0/test/validator-amp-story.out
@@ -30,7 +30,7 @@ PASS
 |    <script async custom-element="amp-story" src="https://cdn.ampproject.org/v0/amp-story-1.0.js"></script>
 |  </head>
 |  <body>
-|    <amp-story standalone title="My Story" publisher="Me" publisher-logo-src="http://me.com/logo.png" poster-portrait-src="http://me.com/portrait.jpg" poster-square-src="http://me.com/square.jpg" poster-landscape-src="http://me.com/landscape.jpg" background-audio="http://me.com/path/to/my.mp3">
+|    <amp-story standalone title="My Story" publisher="Me" publisher-logo-src="http://me.com/logo.png" poster-portrait-src="http://me.com/portrait.jpg" poster-square-src="http://me.com/square.jpg" poster-landscape-src="http://me.com/landscape.jpg" background-audio="http://me.com/path/to/my.mp3" entity="Someone else" entity-logo-src="http://someoneelse.com/logo.png" entity-url="http://someoneelse.com/profile">
 |      <amp-story-page id="1" background-audio="path/to/my.mp3" auto-advance-after="any-value">
 |        <amp-story-grid-layer template="horizontal">
 |          <h5 animate-in="drop">
diff --git a/extensions/amp-story/amp-story.md b/extensions/amp-story/amp-story.md
@@ -251,6 +251,18 @@ The `amp-story` component represents an entire story. The component itself imple
     <td width="40%"><strong>poster-landscape-src [optional]</strong></td>
     <td>A URL to the <a href="#poster-guidelines-(for-poster-portrait-src,-poster-landscape-src,-and-poster-square-src)">story poster</a> in landscape format (4x3 aspect ratio).</td>
   </tr>
+  <tr id="entity">
+    <td width="40%"><strong>entity [optional]</strong></td>
+    <td>The name of the story's creating entity. For example: <code>entity="User"</code>, where User created the story on the publisher's platform.</td>
+  </tr>
+  <tr id="entity-logo-src">
+    <td width="40%"><strong>entity-logo-src [optional]</strong></td>
+    <td>A URL to the story creating entity's logo in square format (1x1 aspect ratio). For example <code>entity-logo-src="https://example.com/logo/1x1.png"</code>, where 1x1.png is a 96x96 px logo.</td>
+  </tr>
+  <tr id="entity-url">
+    <td width="40%"><strong>entity-url [optional]</strong></td>
+    <td>A URL to the story creating entity's platform. For example <code>entity-url="https://example.com/profile/user"</code>, which links to User's profile on the publisher's platform.</td>
+  </tr>
   <tr id="supports-landscape">
     <td width="40%"><strong>supports-landscape [optional]</strong></td>
     <td>Enables landscape orientation support on mobile devices and a full bleed landscape experience on desktop devices.</td>
diff --git a/extensions/amp-story/validator-amp-story.protoascii b/extensions/amp-story/validator-amp-story.protoascii
@@ -41,6 +41,23 @@ tags: {  # <amp-story>
       protocol: "https"
     }
   }
+  attrs: {
+    name: "entity"
+  }
+  attrs: {
+    name: "entity-logo-src"
+    value_url: {
+      protocol: "http"
+      protocol: "https"
+    }
+  }
+  attrs: {
+    name: "entity-url"
+    value_url: {
+      protocol: "http"
+      protocol: "https"
+    }
+  }
   attrs: {
     name: "poster-landscape-src"
     value_url: {
