fix(Workflow): Avoid bubbling up "Unknown encoding" error to user (temporalio#133)

vkarpov15 · web-flow · commit 0a831f77d6c0 · 2021-06-23T19:01:23.000Z
* fix(worker): Fail activity execution if arguments failed to parse

* refactor(worker): Use unknown instead of any based on code review comments
diff --git a/packages/worker/src/worker.ts b/packages/worker/src/worker.ts
@@ -638,7 +638,20 @@ export class Worker<T extends WorkerSpec = DefaultWorkerSpec> {
                   };
                   break;
                 }
-                const args = arrayFromPayloads(this.options.dataConverter, task.start?.input);
+                let args: unknown[];
+                try {
+                  args = arrayFromPayloads(this.options.dataConverter, task.start?.input);
+                } catch (err) {
+                  output = {
+                    type: 'result',
+                    result: {
+                      failed: {
+                        failure: { message: `Failed to parse activity args for activity ${fnName}: ${err.message}` },
+                      },
+                    },
+                  };
+                  break;
+                }
                 const headers = new Map(Object.entries(task.start?.headerFields ?? {}));
                 const input = {
                   args,
