Add error log for worker failure reason, fix test-worker-activities

bergundy · bergundy · commit 5deae8e1ddad · 2021-04-27T20:48:21.000+03:00
diff --git a/packages/test/src/mock-native-worker.ts b/packages/test/src/mock-native-worker.ts
@@ -1,6 +1,7 @@
 /* eslint-disable @typescript-eslint/no-non-null-assertion */
 import { v4 as uuid4 } from 'uuid';
 import { coresdk } from '@temporalio/proto';
+import { msStrToTs } from '@temporalio/workflow/commonjs/time';
 import { defaultDataConverter } from '@temporalio/workflow/commonjs/converter/data-converter';
 import {
   Worker as RealWorker,
@@ -11,6 +12,22 @@ import {
 } from '@temporalio/worker/lib/worker';
 import { sleep } from '@temporalio/worker/lib/utils';
 
+function addActivityStartDefaults(task: coresdk.activity_task.IActivityTask) {
+  // Add some defaults for convenience
+  if (task.start) {
+    task.start = {
+      attempt: 1,
+      startedTime: msStrToTs('0 seconds'),
+      currentAttemptScheduledTime: msStrToTs('0 seconds'),
+      startToCloseTimeout: msStrToTs('1 minute'),
+      scheduleToCloseTimeout: msStrToTs('1 minute'),
+      heartbeatTimeout: msStrToTs('1 minute'),
+      scheduledTime: msStrToTs('0 seconds'),
+      ...task.start,
+    };
+  }
+}
+
 export type Task =
   | { workflow: coresdk.workflow_activation.IWFActivation }
   | { activity: coresdk.activity_task.IActivityTask };
@@ -72,6 +89,7 @@ export class MockNativeWorker implements NativeWorkerLike {
       const buffer = arr.buffer.slice(arr.byteOffset, arr.byteOffset + arr.byteLength);
       this.workflowActivations.unshift(Promise.resolve(buffer));
     } else {
+      addActivityStartDefaults(task.activity);
       const arr = coresdk.activity_task.ActivityTask.encode(task.activity).finish();
       const buffer = arr.buffer.slice(arr.byteOffset, arr.byteOffset + arr.byteLength);
       this.activityTasks.unshift(Promise.resolve(buffer));
@@ -92,6 +110,7 @@ export class MockNativeWorker implements NativeWorkerLike {
   }
 
   public async runActivityTask(task: coresdk.activity_task.IActivityTask): Promise<coresdk.ActivityTaskCompletion> {
+    addActivityStartDefaults(task);
     const arr = coresdk.activity_task.ActivityTask.encode(task).finish();
     const buffer = arr.buffer.slice(arr.byteOffset, arr.byteOffset + arr.byteLength);
     const result = await new Promise<ArrayBuffer>((resolve) => {
diff --git a/packages/test/src/test-worker-activities.ts b/packages/test/src/test-worker-activities.ts
@@ -2,6 +2,7 @@
 import anyTest, { TestInterface, ExecutionContext } from 'ava';
 import { v4 as uuid4 } from 'uuid';
 import { coresdk } from '@temporalio/proto';
+import { DefaultLogger } from '@temporalio/worker';
 import { defaultDataConverter } from '@temporalio/workflow/commonjs/converter/data-converter';
 import { httpGet } from '../../test-activities/lib';
 import { Worker } from './mock-native-worker';
diff --git a/packages/worker/src/worker.ts b/packages/worker/src/worker.ts
@@ -764,7 +764,8 @@ export class Worker {
       )
         .pipe(
           tap({
-            error: () => {
+            error: (error) => {
+              this.log.error('Worker failed', { error });
               this.state = 'FAILED';
             },
           })
