Log missing hostName in Collection.RedirectingCanonicalURL

thebaer · thebaer · commit 4faf41ae7ffd · 2019-07-22T14:22:41.000-04:00
This is the crucial part where the hostName is needed for federation and
API clients. This change at least lets us know when we mess up like this
so the issue is easier to catch in the future.
diff --git a/collections.go b/collections.go
@@ -211,6 +211,10 @@ func (c *Collection) DisplayCanonicalURL() string {
 }
 
 func (c *Collection) RedirectingCanonicalURL(isRedir bool) string {
+	if c.hostName == "" {
+		// If this is true, the human programmers screwed up. So ask for a bug report and fail, fail, fail
+		log.Error("[PROGRAMMER ERROR] WARNING: Collection.hostName is empty! Federation and many other things will fail! If you're seeing this in the wild, please report this bug and let us know what you were doing just before this: https://github.com/writeas/writefreely/issues/new?template=bug_report.md")
+	}
 	if isSingleUser {
 		return c.hostName + "/"
 	}

Original file line number	Diff line number	Diff line change
`@@ -211,6 +211,10 @@ func (c *Collection) DisplayCanonicalURL() string {`
`211`	`211`	`}`
`212`	`212`
`213`	`213`	`func (c *Collection) RedirectingCanonicalURL(isRedir bool) string {`
	`214`	`+ if c.hostName == "" {`
	`215`	`+ // If this is true, the human programmers screwed up. So ask for a bug report and fail, fail, fail`
	`216`	`+ log.Error("[PROGRAMMER ERROR] WARNING: Collection.hostName is empty! Federation and many other things will fail! If you're seeing this in the wild, please report this bug and let us know what you were doing just before this: https://github.com/writeas/writefreely/issues/new?template=bug_report.md")`
	`217`	`+ }`
`214`	`218`	`if isSingleUser {`
`215`	`219`	`return c.hostName + "/"`
`216`	`220`	`}`