Added capture for icon-anchor and div-icon style #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewgryan
reviewed
Aug 29, 2025
| if (pane !== null) { | ||
| options["pane"] = pane.getAttribute("name"); | ||
| } | ||
| const style = this.getAttribute("style"); |
Owner
There was a problem hiding this comment.
Does this cause problems with native browser styling?
Owner
There was a problem hiding this comment.
On second thoughts, https://leafletjs.com/reference.html#path-option, Path options aren't similar enough to native browser style options to force an unintuitive api usage
andrewgryan
approved these changes
Aug 29, 2025
Owner
andrewgryan
left a comment
There was a problem hiding this comment.
The only concern I had was a potential conflict of using the style attribute for Leaflet purposes without overriding or avoiding the native browser usage of the style attribute. This is an acceptable risk and conforms to the Leaflet-HTML guidance on attribute definitions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.