Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 593f902

Browse files
SkyZeroZxthePunderWoman
authored andcommitted
refactor(platform-browser): remove unused Platform ID dependency from DomRendererFactory2
Eliminates the unnecessary injection and usage of Platform ID in the renderer factory logic, along with related test scaffolding cleanup (cherry picked from commit 5343001)
1 parent de2ff12 commit 593f902

File tree

3 files changed

+0
-4
lines changed

3 files changed

+0
-4
lines changed

‎packages/core/test/acceptance/renderer_factory_spec.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -402,7 +402,6 @@ function getRendererFactory2(document: Document): RendererFactory2 {
402402
appId,
403403
true,
404404
document,
405-
isNode ? PLATFORM_SERVER_ID : PLATFORM_BROWSER_ID,
406405
fakeNgZone,
407406
null,
408407
);

‎packages/core/test/render3/imported_renderer2.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ export function getRendererFactory2(document: any): RendererFactory2 {
6060
appId,
6161
true,
6262
document,
63-
isNode ? PLATFORM_SERVER_ID : PLATFORM_BROWSER_ID,
6463
fakeNgZone,
6564
null,
6665
);

‎packages/platform-browser/src/dom/dom_renderer.ts‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import {
1515
InjectionToken,
1616
NgZone,
1717
OnDestroy,
18-
PLATFORM_ID,
1918
Renderer2,
2019
RendererFactory2,
2120
RendererStyleFlags2,
@@ -143,7 +142,6 @@ export class DomRendererFactory2 implements RendererFactory2, OnDestroy {
143142
@Inject(APP_ID) private readonly appId: string,
144143
@Inject(REMOVE_STYLES_ON_COMPONENT_DESTROY) private removeStylesOnCompDestroy: boolean,
145144
@Inject(DOCUMENT) private readonly doc: Document,
146-
@Inject(PLATFORM_ID) readonly platformId: Object,
147145
readonly ngZone: NgZone,
148146
@Inject(CSP_NONCE) private readonly nonce: string | null = null,
149147
@Inject(TracingService)

0 commit comments

Comments
 (0)