Revert "feat(forms): add ability to clear a FormRecord (#50750)" (#58315)

AndrewKushnir · AndrewKushnir · commit 79d9be3e6309 · 2024-10-22T14:04:45.000-07:00
This reverts commit 3e7d724. PR Close #58315
diff --git a/goldens/public-api/forms/index.api.md b/goldens/public-api/forms/index.api.md
@@ -534,9 +534,6 @@ export interface FormRecord<TControl> {
     addControl(name: string, control: TControl, options?: {
         emitEvent?: boolean;
     }): void;
-    clear(options?: {
-        emitEvent?: boolean;
-    }): void;
     contains(controlName: string): boolean;
     getRawValue(): {
         [key: string]: ɵRawValue<TControl>;
diff --git a/packages/forms/src/model/form_group.ts b/packages/forms/src/model/form_group.ts
@@ -724,25 +724,7 @@ export const isFormGroup = (control: unknown): control is FormGroup => control i
  */
 export class FormRecord<TControl extends AbstractControl = AbstractControl> extends FormGroup<{
   [key: string]: TControl;
-}> {
-  /**
-   * Clear all controls from this record.
-   *
-   * This method also updates the value and validity of the control.
-   *
-   * @param options Specifies whether this FormGroup instance should emit events after a
-   *     control is removed.
-   * * `emitEvent`: When true or not supplied (the default), both the `statusChanges` and
-   * `valueChanges` observables emit events with the latest status and value when the controls are
-   * removed. When false, no events are emitted.
-   */
-  clear(options: {emitEvent?: boolean} = {}): void {
-    this._forEachChild((child) => child._registerOnCollectionChange(() => {}));
-    this.controls = {};
-    this.updateValueAndValidity({emitEvent: options.emitEvent});
-    this._onCollectionChange();
-  }
-}
+}> {}
 
 export interface FormRecord<TControl> {
   /**
@@ -766,19 +748,6 @@ export interface FormRecord<TControl> {
    */
   removeControl(name: string, options?: {emitEvent?: boolean}): void;
 
-  /**
-   * Clear all controls from this record.
-   *
-   * This method also updates the value and validity of the control.
-   *
-   * @param options Specifies whether this FormGroup instance should emit events after a
-   *     control is removed.
-   * * `emitEvent`: When true or not supplied (the default), both the `statusChanges` and
-   * `valueChanges` observables emit events with the latest status and value when the controls are
-   * removed. When false, no events are emitted.
-   */
-  clear(options?: {emitEvent?: boolean}): void;
-
   /**
    * Replace an existing control.
    *
diff --git a/packages/forms/test/form_group_spec.ts b/packages/forms/test/form_group_spec.ts
@@ -13,7 +13,6 @@ import {
   FormArray,
   FormControl,
   FormGroup,
-  FormRecord,
   ValidationErrors,
   Validators,
   ValueChangeEvent,
@@ -2587,39 +2586,5 @@ import {StatusChangeEvent} from '../src/model/abstract_model';
       });
       expect(consoleWarnSpy).toHaveBeenCalledTimes(1);
     });
-
-    describe('clear()', () => {
-      let c1: FormControl;
-      let c2: FormControl;
-      let r: FormRecord;
-
-      beforeEach(() => {
-        c1 = new FormControl('one');
-        c2 = new FormControl('two');
-        r = new FormRecord({one: c1, two: c2});
-      });
-
-      it('should remove control if new control is null', () => {
-        r.clear();
-        expect(r.controls['one']).not.toBeDefined();
-        expect(r.controls['two']).not.toBeDefined();
-        expect(r.value).toEqual({});
-      });
-
-      it('should only emit value change event once', () => {
-        const logger: string[] = [];
-        r.valueChanges.subscribe(() => logger.push('change!'));
-        r.clear();
-        expect(logger).toEqual(['change!']);
-      });
-
-      it('should not emit event when `FormGroup.clearControls` called with `emitEvent: false`', () => {
-        const logger: string[] = [];
-        r.valueChanges.subscribe(() => logger.push('value change'));
-        r.statusChanges.subscribe(() => logger.push('status change'));
-        r.clear({emitEvent: false});
-        expect(logger).toEqual([]);
-      });
-    });
   });
 })();
