refactor(compiler): remove unused field from output AST (#58444)

crisbeto · thePunderWoman · commit abd0da7265fb · 2024-11-01T14:32:57.000Z
The `ExternalReference.runtime` field wasn't being used anywhere. PR Close #58444
diff --git a/packages/compiler/src/output/output_ast.ts b/packages/compiler/src/output/output_ast.ts
@@ -886,8 +886,7 @@ export class ExternalExpr extends Expression {
     return (
       e instanceof ExternalExpr &&
       this.value.name === e.value.name &&
-      this.value.moduleName === e.value.moduleName &&
-      this.value.runtime === e.value.runtime
+      this.value.moduleName === e.value.moduleName
     );
   }
 
@@ -908,7 +907,6 @@ export class ExternalReference {
   constructor(
     public moduleName: string | null,
     public name: string | null,
-    public runtime?: any | null,
   ) {}
   // Note: no isEquivalent method here as we use this as an interface too.
 }
diff --git a/packages/compiler/test/output/output_jit_spec.ts b/packages/compiler/test/output/output_jit_spec.ts
@@ -16,12 +16,10 @@ describe('Output JIT', () => {
   describe('regression', () => {
     it('should generate unique argument names', () => {
       const externalIds = newArray(10, 1).map(
-        (_, index) =>
-          new o.ExternalReference('@angular/core', `id_${index}_`, {name: `id_${index}_`}),
+        (_, index) => new o.ExternalReference('@angular/core', `id_${index}_`),
       );
       const externalIds1 = newArray(10, 1).map(
-        (_, index) =>
-          new o.ExternalReference('@angular/core', `id_${index}_1`, {name: `id_${index}_1`}),
+        (_, index) => new o.ExternalReference('@angular/core', `id_${index}_1`),
       );
       const ctx = EmitterVisitorContext.createRoot();
       const reflectorContext: {[key: string]: string} = {};
