fixup 4

gkalpak · gkalpak · commit 223fb5238c97 · 2016-02-22T12:17:12.000+02:00
Ensure that `angular.element.cleanData()`:

1. has been called with the expected arguments (not necessary, since the next test will verify that)
2. has indeed cleaned up the element's data (e.g. there was a bug in `testabilityPatch.js`, where
   `cleanData()` was called with an array of jq-wrapped elements, instead of "raw" nodes, which
   silently failed to clean up)
diff --git a/test/ngMock/angular-mocksSpec.js b/test/ngMock/angular-mocksSpec.js
@@ -2430,7 +2430,7 @@ describe('`afterEach` clean-up', function() {
 
           // Spy on `angular.element.cleanData()`, so the next test can verify
           // that it has been called as necessary
-          prevCleanDataSpy = spyOn(angular.element, 'cleanData').andCallThrough();
+          prevCleanDataSpy = mockCleanData([null, [prevRootElement]]);
 
           return $delegate;
         });
@@ -2471,7 +2471,7 @@ describe('`afterEach` clean-up', function() {
 
           // Spy on `angular.element.cleanData()`, so the next test can verify
           // that it has been called as necessary
-          prevCleanDataSpy = spyOn(angular.element, 'cleanData').andCallThrough();
+          prevCleanDataSpy = mockCleanData([null, [prevOriginalRootElement, prevRootElement]]);
 
           return prevRootElement;
         });
@@ -2526,4 +2526,31 @@ describe('`afterEach` clean-up', function() {
       inject(function() {});
     });
   });
+
+
+  // Helpers
+  function mockCleanData(expectedElementsPerCall) {
+    var jq = angular.element;
+    var callIdx = -1;
+
+    var cleanData_ = jq.cleanData;
+    var cleanDataSpy = spyOn(jq, 'cleanData').andCallFake(function(cleanUpNodes) {
+      var expectedElements = expectedElementsPerCall[++callIdx];
+
+      if (!expectedElements) {
+        cleanData_.apply(jq, arguments);
+      } else {
+        var expectedNodes = expectedElements.map(function(elem) { return elem[0]; });
+        expect(cleanUpNodes).toEqual(expectedNodes);
+
+        cleanData_.apply(jq, arguments);
+
+        expectedNodes.forEach(function(node) {
+          expect(jq.hasData(node)).toBe(false);
+        });
+      }
+    });
+
+    return cleanDataSpy;
+  }
 });
