the right way to remove elements and splice from array

thebigredgeek · thebigredgeek · commit d36663950253 · 2014-08-29T10:06:09.000-07:00
diff --git a/src/ng/directive/ngSwitch.js b/src/ng/directive/ngSwitch.js
@@ -146,18 +146,15 @@ var ngSwitchDirective = ['$animate', function($animate) {
 
       scope.$watch(watchExpr, function ngSwitchWatchAction(value) {
         var i, ii;
-        for (i = 0, ii = previousElements.length; i < ii; ++i) {
-          previousElements[i].remove();
-        }
-        previousElements.length = 0;
-
         for (i = 0, ii = selectedScopes.length; i < ii; ++i) {
           var selected = getBlockNodes(selectedElements[i].clone);
           selectedScopes[i].$destroy();
           previousElements[i] = selected;
-          $animate.leave(selected).then(function() {
-            previousElements[i] ? previousElements.splice(i, 1) : angular.noop();
-          });
+          $animate.leave(selected).then((function(i) {
+            return function(){
+              previousElements.splice(i, 1).remove();
+            };
+          }(i));
         }
 
         selectedElements.length = 0;
