This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngMock): don't break if $rootScope.$destroy() is not a function
#14107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `angular-mocks` was calling `$rootScope.$destroy()` after each test as part of it's cleaning up, assuming that it was always available. This could break if `$rootScope` was mocked and the mocked version didn't provide the `$destroy()` method. This commit prevents the error by first checking that `$rootScope.$destroy` is present. Fixes angular#14106
| @@ -2612,7 +2612,8 @@ if (window.jasmine || window.mocha) { | |||
| } | |||
| angular.element.cleanData(cleanUpNodes); | |||
|
|
|||
| injector.get('$rootScope').$destroy(); | |||
| var $rootScope = injector.get('$rootScope'); | |||
| if ($rootScope.$destroy) $rootScope.$destroy(); | |||
There was a problem hiding this comment.
can you add a comment about this being possibly undefined due to mocking?
|
LGTM |
gkalpak
added a commit
that referenced
this pull request
Feb 23, 2016
Previously, `angular-mocks` was calling `$rootScope.$destroy()` after each test as part of it's cleaning up, assuming that it was always available. This could break if `$rootScope` was mocked and the mocked version didn't provide the `$destroy()` method. This commit prevents the error by first checking that `$rootScope.$destroy` is present. Fixes #14106 Closes #14107
gkalpak
added a commit
that referenced
this pull request
Feb 23, 2016
Previously, `angular-mocks` was calling `$rootScope.$destroy()` after each test as part of it's cleaning up, assuming that it was always available. This could break if `$rootScope` was mocked and the mocked version didn't provide the `$destroy()` method. This commit prevents the error by first checking that `$rootScope.$destroy` is present. Fixes #14106 Closes #14107
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
angular-mockswas calling$rootScope.$destroy()after each test as part of it's cleaning up, assuming that it was always available. This could break if$rootScopewas mocked and the mocked version didn't provide the$destroy()method.This commit prevents the error by first checking that
$rootScope.$destroyis present.Fixes #14106