From ae058df97b00d0cad578755fdc84922b285136dc Mon Sep 17 00:00:00 2001 From: Valeriy Date: Tue, 10 Jun 2014 23:41:54 +0300 Subject: [PATCH 1/3] Update ngIf.js Added missing description of ng-if behavior that it will return false for "f", "0", "false", "no", "n", "[]" values because it use toBoolean function --- src/ng/directive/ngIf.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/ng/directive/ngIf.js b/src/ng/directive/ngIf.js index f75674039a1d..24538c17c369 100644 --- a/src/ng/directive/ngIf.js +++ b/src/ng/directive/ngIf.js @@ -16,6 +16,11 @@ * case when this difference is significant is when using css selectors that rely on an element's * position within the DOM, such as the `:first-child` or `:last-child` pseudo-classes. * + *
+ * **Note:** Here is a list of values that ngShow will consider as a falsy value (case insensitive):
+ * "f" / "0" / "false" / "no" / "n" / "[]" + *
+ * * Note that when an element is removed using `ngIf` its scope is destroyed and a new scope * is created when the element is restored. The scope created within `ngIf` inherits from * its parent scope using From bb60f8bef1ed78b6b57a3cf25e2b7f03d48d4725 Mon Sep 17 00:00:00 2001 From: Valeriy Date: Wed, 11 Jun 2014 09:39:25 +0300 Subject: [PATCH 2/3] Update ngIf.js fix cp typo - ngShow -> ngIf --- src/ng/directive/ngIf.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ng/directive/ngIf.js b/src/ng/directive/ngIf.js index 24538c17c369..9f7bd206413d 100644 --- a/src/ng/directive/ngIf.js +++ b/src/ng/directive/ngIf.js @@ -17,8 +17,8 @@ * position within the DOM, such as the `:first-child` or `:last-child` pseudo-classes. * *
- * **Note:** Here is a list of values that ngShow will consider as a falsy value (case insensitive):
- * "f" / "0" / "false" / "no" / "n" / "[]" + * **Note:** Here is a list of values that ngIf will consider as a falsy value (case insensitive):
+ * "f" / "0" / "false" / "no" / "n" / "[]" *
* * Note that when an element is removed using `ngIf` its scope is destroyed and a new scope From ce2d7554f0258837da41ef3e6e8c3bc633877971 Mon Sep 17 00:00:00 2001 From: Valeriy Date: Wed, 11 Jun 2014 12:06:28 +0300 Subject: [PATCH 3/3] Update ngIf.js Trailing whitespace --- src/ng/directive/ngIf.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ng/directive/ngIf.js b/src/ng/directive/ngIf.js index 9f7bd206413d..3f39dec1df83 100644 --- a/src/ng/directive/ngIf.js +++ b/src/ng/directive/ngIf.js @@ -18,9 +18,9 @@ * *
* **Note:** Here is a list of values that ngIf will consider as a falsy value (case insensitive):
- * "f" / "0" / "false" / "no" / "n" / "[]" + * "f" / "0" / "false" / "no" / "n" / "[]" *
- * + * * Note that when an element is removed using `ngIf` its scope is destroyed and a new scope * is created when the element is restored. The scope created within `ngIf` inherits from * its parent scope using