Lint results should not be filtered before being passed to formatterΒ #2543
Description
When using a custom formatter such as ratchet the formatter expects to receive results from all processed files, even empty results. When these are filtered out, it results in odd behavior as noted in this issue: Jmsa/eslint-formatter-ratchet#10
I tested removing this filtering in my local environment and can confirm it fixes the issue, and thus must be different from how the "vanilla" eslint command behaves. At the least, this should be a configurable behavior.
To reproduce, simply install and use the ratchet formatter, then fix all errors in any file so that it is filtered from the output. Ratchet will not be able to tell there were changes to this file.
Versions
| package | version |
|---|---|
@angular-eslint/builder |
19.4.0 |
ESLint |
9.27.0 |
node |
22.14.0 |
# Please run `npx ng version` in your project and paste the full output here:
_ _ ____ _ ___
/ \ _ __ __ _ _ _| | __ _ _ __ / ___| | |_ _|
/ β³ \ | '_ \ / _` | | | | |/ _` | '__| | | | | | |
/ ___ \| | | | (_| | |_| | | (_| | | | |___| |___ | |
/_/ \_\_| |_|\__, |\__,_|_|\__,_|_| \____|_____|___|
|___/
Angular CLI: 19.2.8
Node: 22.14.0
Package Manager: npm 10.9.2
OS: win32 x64
Angular: 19.2.6
... animations, common, compiler, compiler-cli, core, forms
... localize, platform-browser, platform-browser-dynamic, router
Package Version
---------------------------------------------------------
@angular-devkit/architect 0.1902.8
@angular-devkit/build-angular 19.2.8
@angular-devkit/core 16.2.12
@angular-devkit/schematics 19.2.8
@angular/cli 19.2.8
@schematics/angular 19.2.8
rxjs 7.8.2
typescript 5.8.3
zone.js 0.15.0
- I have updated to the latest supported version of the packages and checked my
ng versionoutput per the instructions given here.
I know I am not on the latest major version but I have confirmed that the code in question that I tested changing is still present in the codebase.