refactor(soba): clean up

nartc · nartc · commit 13815128ca29 · 2025-03-16T21:17:56.000-05:00
diff --git a/apps/examples/src/app/theatre/basic/basic.ts b/apps/examples/src/app/theatre/basic/basic.ts
@@ -8,9 +8,7 @@ import stateJson from './state.json';
 	template: `
 		<ngt-canvas shadows>
 			<theatre-project *canvasContent studio [config]="{ state }">
-				<theatre-sheet [sequence]="{ autoplay: true, iterationCount: Infinity }">
-					<app-scene-graph />
-				</theatre-sheet>
+				<app-scene-graph sheet [sequence]="{ autoplay: true, iterationCount: Infinity }" />
 			</theatre-project>
 		</ngt-canvas>
 	`,
diff --git a/apps/examples/src/app/theatre/basic/scene.ts b/apps/examples/src/app/theatre/basic/scene.ts
@@ -1,5 +1,5 @@
 import { ChangeDetectionStrategy, Component, CUSTOM_ELEMENTS_SCHEMA, signal, viewChild } from '@angular/core';
-import { injectBeforeRender, NgtArgs } from 'angular-three';
+import { injectBeforeRender } from 'angular-three';
 import { NgtsRoundedBox } from 'angular-three-soba/abstractions';
 import { NgtsPerspectiveCamera } from 'angular-three-soba/cameras';
 import { TheatreSheetObject, TheatreSheetObjectTransform } from 'angular-three-theatre';
@@ -46,7 +46,7 @@ import { TheatreSheetObject, TheatreSheetObjectTransform } from 'angular-three-t
 		</ngt-mesh>
 	`,
 	schemas: [CUSTOM_ELEMENTS_SCHEMA],
-	imports: [NgtArgs, TheatreSheetObject, NgtsRoundedBox, NgtsPerspectiveCamera],
+	imports: [TheatreSheetObject, NgtsRoundedBox, NgtsPerspectiveCamera],
 	changeDetection: ChangeDetectionStrategy.OnPush,
 	host: { class: 'experience-basic-theatre', '(document:keyup)': 'onKeyup($event)' },
 })
diff --git a/libs/soba/misc/src/lib/sampler.ts b/libs/soba/misc/src/lib/sampler.ts
@@ -172,8 +172,6 @@ export class NgtsSampler {
 	options = input(defaultOptions, { transform: mergeInputs(defaultOptions) });
 	protected parameters = omit(this.options, ['weight', 'transform', 'count']);
 
-	// NOTE: this could have been a viewChild.required, but we need to _try_ to consume
-	//  this Signal earlier than when a viewChild.required would resolve.
 	groupRef = viewChild.required<ElementRef<THREE.Group>>('group');
 
 	private count = pick(this.options, 'count');
@@ -209,9 +207,9 @@ export class NgtsSampler {
 			) as unknown as THREE.InstancedMesh;
 		});
 
-		// NOTE: because injectSurfaceSampler returns a computed, we need to consume
+		// NOTE: because surfaceSampler returns a computed, we need to consume
 		//  this computed in a Reactive Context (an effect) to ensure the inner logic of
-		//  injectSurfaceSampler is run properly.
+		//  surfaceSampler is run properly.
 		const sampler = surfaceSampler(meshToSample, {
 			count: this.count,
 			transform: this.transform,
diff --git a/libs/soba/staging/src/lib/accumulative-shadows.ts b/libs/soba/staging/src/lib/accumulative-shadows.ts
@@ -81,8 +81,8 @@ const defaultOptions: NgtsAccumulativeShadowsOptions = {
 	changeDetection: ChangeDetectionStrategy.OnPush,
 })
 export class NgtsAccumulativeShadows {
-	nullTraversal = () => null;
-	Math = Math;
+	protected readonly nullTraversal = () => null;
+	protected readonly Math = Math;
 
 	options = input(defaultOptions, { transform: mergeInputs(defaultOptions) });
 	parameters = omit(this.options, [
