refactor(soba/cameras): bring makeDefault effect on top for orthographic

nartc · nartc · commit 52a24031d8d1 · 2025-03-16T21:16:08.000-05:00
diff --git a/libs/soba/cameras/src/lib/orthographic-camera.ts b/libs/soba/cameras/src/lib/orthographic-camera.ts
@@ -103,6 +103,15 @@ export class NgtsOrthographicCamera {
 	constructor() {
 		extend({ OrthographicCamera, Group });
 
+		effect((onCleanup) => {
+			const makeDefault = this.makeDefault();
+			if (!makeDefault) return;
+
+			const oldCam = this.store.snapshot.camera;
+			this.store.update({ camera: this.cameraRef().nativeElement });
+			onCleanup(() => this.store.update(() => ({ camera: oldCam })));
+		});
+
 		effect(() => {
 			this.cameraRef().nativeElement.updateProjectionMatrix();
 		});
@@ -115,15 +124,6 @@ export class NgtsOrthographicCamera {
 			camera.updateProjectionMatrix();
 		});
 
-		effect((onCleanup) => {
-			const makeDefault = this.makeDefault();
-			if (!makeDefault) return;
-
-			const oldCam = this.store.snapshot.camera;
-			this.store.update({ camera: this.cameraRef().nativeElement });
-			onCleanup(() => this.store.update(() => ({ camera: oldCam })));
-		});
-
 		let count = 0;
 		let oldEnvMap: THREE.Color | THREE.Texture | null = null;
 		injectBeforeRender(({ gl, scene }) => {
