refactor(soba/misc): use onCleanup to clean up fbo embedded view

nartc · nartc · commit 771d55f2d87f · 2025-03-24T14:23:03.000-05:00
diff --git a/libs/soba/misc/src/lib/fbo.ts b/libs/soba/misc/src/lib/fbo.ts
@@ -1,7 +1,6 @@
 import {
 	DestroyRef,
 	Directive,
-	EmbeddedViewRef,
 	Injector,
 	TemplateRef,
 	ViewContainerRef,
@@ -113,20 +112,15 @@ export class NgtsFBO {
 	private viewContainerRef = inject(ViewContainerRef);
 
 	constructor() {
-		let ref: EmbeddedViewRef<{ $implicit: ReturnType<typeof fbo> }>;
-
 		const fboTarget = fbo(() => {
 			const { width, height, ...settings } = this.fbo();
 			return { width, height, settings };
 		});
 
-		effect(() => {
-			ref = this.viewContainerRef.createEmbeddedView(this.template, { $implicit: fboTarget });
+		effect((onCleanup) => {
+			const ref = this.viewContainerRef.createEmbeddedView(this.template, { $implicit: fboTarget });
 			ref.detectChanges();
-		});
-
-		inject(DestroyRef).onDestroy(() => {
-			ref?.destroy();
+			onCleanup(() => void ref.destroy());
 		});
 	}
 
