refactor(core): remove unnecessary portal injectors handling

Chau · Chau · commit 79970722f621 · 2025-03-31T22:17:38.000-05:00
diff --git a/libs/core/src/lib/portal.ts b/libs/core/src/lib/portal.ts
@@ -21,7 +21,7 @@ import * as THREE from 'three';
 import { Group } from 'three';
 import { getInstanceState, prepare } from './instance';
 import { extend } from './renderer/catalogue';
-import { NGT_DOM_PARENT_FLAG, NGT_INTERNAL_ADD_COMMENT_FLAG, NGT_PORTAL_CONTENT_FLAG } from './renderer/constants';
+import { NGT_DOM_PARENT_FLAG, NGT_PORTAL_CONTENT_FLAG } from './renderer/constants';
 import { injectStore, NGT_STORE } from './store';
 import type { NgtComputeFunction, NgtEventManager, NgtSize, NgtState, NgtViewport } from './types';
 import { is } from './utils/is';
@@ -97,11 +97,6 @@ export class NgtPortalContent {
 		commentNode.data = NGT_PORTAL_CONTENT_FLAG;
 		commentNode[NGT_PORTAL_CONTENT_FLAG] = store;
 		commentNode[NGT_DOM_PARENT_FLAG] = host.nativeElement;
-
-		if (commentNode[NGT_INTERNAL_ADD_COMMENT_FLAG]) {
-			commentNode[NGT_INTERNAL_ADD_COMMENT_FLAG]('portal', injector);
-			delete commentNode[NGT_INTERNAL_ADD_COMMENT_FLAG];
-		}
 	}
 }
 
diff --git a/libs/core/src/lib/renderer/renderer.ts b/libs/core/src/lib/renderer/renderer.ts
@@ -107,7 +107,6 @@ export class NgtRendererFactory2 implements RendererFactory2 {
 export class NgtRenderer2 implements Renderer2 {
 	private argsInjectors: Array<Injector> = [];
 	private parentInjectors: Array<Injector> = [];
-	private portalInjectors: Array<Injector> = [];
 
 	constructor(
 		public delegateRenderer: Renderer2,
@@ -135,7 +134,6 @@ export class NgtRenderer2 implements Renderer2 {
 		this.count = 0;
 		this.argsInjectors = [];
 		this.parentInjectors = [];
-		this.portalInjectors = [];
 	}
 
 	createElement(name: string, namespace?: string | null) {
@@ -220,7 +218,7 @@ export class NgtRenderer2 implements Renderer2 {
 		//  In our directives, we can call this function to then start tracking the RendererNode
 		//  this is done to limit the amount of Nodes we need to process for getCreationState
 		Object.assign(commentRendererNode, {
-			[NGT_INTERNAL_ADD_COMMENT_FLAG]: (type: 'args' | 'parent' | 'portal', injector: Injector) => {
+			[NGT_INTERNAL_ADD_COMMENT_FLAG]: (type: 'args' | 'parent', injector: Injector) => {
 				if (type === 'args') {
 					this.argsInjectors.push(injector);
 				} else if (type === 'parent') {
@@ -230,8 +228,6 @@ export class NgtRenderer2 implements Renderer2 {
 						},
 					});
 					this.parentInjectors.push(injector);
-				} else if (type === 'portal') {
-					this.portalInjectors.push(injector);
 				}
 
 				commentRendererNode.__ngt_renderer__[NgtRendererClassId.injector] = injector;
