refactor(core): clean up

Chau · Chau · commit e42b727325cb · 2025-04-09T21:47:36.000-05:00
diff --git a/libs/core/src/lib/portal.ts b/libs/core/src/lib/portal.ts
@@ -39,9 +39,10 @@ export class NgtPortalAutoRender {
 	renderPriority = input(1, { alias: 'autoRender', transform: (value) => numberAttribute(value, 1) });
 
 	constructor() {
-		effect(() => {
-			// this.portalStore.update((state) => ({ events: { ...state.events, priority: this.renderPriority() + 1 } }));
-		});
+		// TODO: (chau) investigate if this is still needed
+		// effect(() => {
+		// this.portalStore.update((state) => ({ events: { ...state.events, priority: this.renderPriority() + 1 } }));
+		// });
 
 		effect((onCleanup) => {
 			const portalRendered = this.portal.portalRendered();
diff --git a/libs/core/src/lib/store.ts b/libs/core/src/lib/store.ts
@@ -211,10 +211,7 @@ export function storeFactory() {
 	} = store.snapshot;
 
 	effect(() => {
-		const newCamera = store.camera();
-		const newSize = store.size();
-		const newDpr = store.viewport.dpr();
-		const gl = store.gl();
+		const [newCamera, newSize, newDpr, gl] = [store.camera(), store.size(), store.viewport.dpr(), store.gl()];
 
 		// Resize camera and renderer on changes to size and pixel-ratio
 		if (newSize !== oldSize || newDpr !== oldDpr) {
