Added: Max interval too low warning. (#3847)

Luc-Mcgrady · web-flow · commit cad6e0b0bfd0 · 2025-03-10T16:14:35.000+07:00
* Added: Max interval too low warning.

* Lower threshold to 180

* Add self to about.py
diff --git a/ftl/core/deck-config.ftl b/ftl/core/deck-config.ftl
@@ -371,6 +371,7 @@ deck-config-learning-step-above-graduating-interval = The graduating interval sh
 deck-config-good-above-easy = The easy interval should be at least as long as the graduating interval.
 deck-config-relearning-steps-above-minimum-interval = The minimum lapse interval should be at least as long as your final relearning step.
 deck-config-maximum-answer-secs-above-recommended = Anki can schedule your reviews more efficiently when you keep each question short.
+deck-config-too-short-maximum-interval = A maximum interval less than 6 months is not recommended.
 
 ## Selecting a deck
 
diff --git a/qt/aqt/about.py b/qt/aqt/about.py
@@ -215,6 +215,7 @@ def on_dialog_destroyed() -> None:
             "Danika_Dakika",
             "Marcelo Vasconcelos",
             "Mumtaz Hajjo Alrifai",
+            "Luc Mcgrady",
             "Brayan Oliveira",
         )
     )
diff --git a/ts/routes/deck-options/AdvancedOptions.svelte b/ts/routes/deck-options/AdvancedOptions.svelte
@@ -20,6 +20,7 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
     import SpinBoxFloatRow from "./SpinBoxFloatRow.svelte";
     import SpinBoxRow from "./SpinBoxRow.svelte";
     import DateInput from "./DateInput.svelte";
+    import Warning from "./Warning.svelte";
 
     export let state: DeckOptionsState;
     export let api: Record<string, never>;
@@ -83,6 +84,13 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
     };
     const helpSections: HelpItem[] = Object.values(settings);
 
+    $: maxIntervalWarningClass =
+        $config.maximumReviewInterval < 50 ? "alert-danger" : "alert-warning";
+    $: maxIntervalWarning =
+        $config.maximumReviewInterval < 180
+            ? tr.deckConfigTooShortMaximumInterval()
+            : "";
+
     let modal: Modal;
     let carousel: Carousel;
 
@@ -121,6 +129,11 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
             </SpinBoxRow>
         </Item>
 
+        <Item>
+            <Warning warning={maxIntervalWarning} className={maxIntervalWarningClass}
+            ></Warning>
+        </Item>
+
         {#if !$fsrs}
             <Item>
                 <SpinBoxFloatRow

Original file line number	Diff line number	Diff line change
`@@ -215,6 +215,7 @@ def on_dialog_destroyed() -> None:`
`215`	`215`	`"Danika_Dakika",`
`216`	`216`	`"Marcelo Vasconcelos",`
`217`	`217`	`"Mumtaz Hajjo Alrifai",`
	`218`	`+ "Luc Mcgrady",`
`218`	`219`	`"Brayan Oliveira",`
`219`	`220`	`)`
`220`	`221`	`)`