Stop triggerers stealing callback triggers from a live triggerer - #73075
Draft
rjgoyln wants to merge 1 commit into
Draft
Stop triggerers stealing callback triggers from a live triggerer#73075rjgoyln wants to merge 1 commit into
rjgoyln wants to merge 1 commit into
Conversation
The callback branch of the trigger-assignment query was the only one without the liveness predicate the task and asset branches carry, so every triggerer reclaimed every callback trigger on each loop regardless of who owned it. In an HA deployment that means a callback trigger is cancelled and restarted as triggerers take turns claiming it, and the no-op reclaims of triggers the triggerer already owns consume the per-loop selection budget that task and asset triggers would otherwise get.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Trigger.get_sorted_triggersbuilds one SELECT each for callback, task-instance and asset triggers. The task and asset SELECTs only take triggers that are unassigned or owned by a dead triggerer; the callback SELECT had no such filter, so every triggerer reclaimed every callback trigger on every pass:The asset SELECT had the same defect until #65792 added the predicate there; callback was missed.
Behavior change
A callback trigger owned by a live triggerer is no longer reassigned, matching task and asset triggers.
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5) following the guidelines