refactor: rename the name of the function that gets all the headers to 'getHeaders'. (#132)

123liubao · web-flow · commit 35159bb2661e · 2022-03-16T11:25:16.000+08:00
diff --git a/runner-core/src/main/java/org/apache/apisix/plugin/runner/handler/HTTPReqCallHandler.java b/runner-core/src/main/java/org/apache/apisix/plugin/runner/handler/HTTPReqCallHandler.java
@@ -199,7 +199,7 @@ private void handleHttpReqCall(ChannelHandlerContext ctx, HttpRequest request) {
     }
 
     private void preReadReq() {
-        currReq.getHeader();
+        currReq.getHeaders();
         currReq.getPath();
         currReq.getMethod();
         currReq.getArgs();
diff --git a/runner-core/src/test/java/org/apache/apisix/plugin/runner/handler/A6HttpCallHandlerTest.java b/runner-core/src/test/java/org/apache/apisix/plugin/runner/handler/A6HttpCallHandlerTest.java
@@ -99,8 +99,8 @@ public void filter(HttpRequest request, HttpResponse response, PluginFilterChain
                     }
                 }
 
-                if (!Objects.isNull(request.getHeader())) {
-                    for (Map.Entry<String, String> header : request.getHeader().entrySet()) {
+                if (!Objects.isNull(request.getHeaders())) {
+                    for (Map.Entry<String, String> header : request.getHeaders().entrySet()) {
                         System.out.println("do filter: header key: " + header.getKey());
                         System.out.println("do filter: header value: " + header.getValue());
                     }
diff --git a/runner-plugin-sdk/src/main/java/org/apache/apisix/plugin/runner/HttpRequest.java b/runner-plugin-sdk/src/main/java/org/apache/apisix/plugin/runner/HttpRequest.java
@@ -138,7 +138,7 @@ public void setPath(String path) {
      *
      * @return the all headers
      */
-    public Map<String, String> getHeader() {
+    public Map<String, String> getHeaders() {
         if (Objects.isNull(headers)) {
             headers = new HashMap<>();
             for (int i = 0; i < req.headersLength(); i++) {
@@ -164,7 +164,7 @@ public Map<String, String> getHeader() {
      * @return the header value or null
      */
     public String getHeader(String headerName) {
-        Map<String, String> headers = getHeader();
+        Map<String, String> headers = getHeaders();
         if (!CollectionUtils.isEmpty(headers)) {
             for (Map.Entry<String, String> header : headers.entrySet()) {
                 if (header.getKey().equals(headerName)) {

Original file line number	Diff line number	Diff line change
`@@ -199,7 +199,7 @@ private void handleHttpReqCall(ChannelHandlerContext ctx, HttpRequest request) {`
`199`	`199`	`}`
`200`	`200`
`201`	`201`	`private void preReadReq() {`
`202`		`- currReq.getHeader();`
	`202`	`+ currReq.getHeaders();`
`203`	`203`	`currReq.getPath();`
`204`	`204`	`currReq.getMethod();`
`205`	`205`	`currReq.getArgs();`
Original file line number	Diff line number	Diff line change
`@@ -99,8 +99,8 @@ public void filter(HttpRequest request, HttpResponse response, PluginFilterChain`
`99`	`99`	`}`
`100`	`100`	`}`
`101`	`101`
`102`		`- if (!Objects.isNull(request.getHeader())) {`
`103`		`- for (Map.Entry<String, String> header : request.getHeader().entrySet()) {`
	`102`	`+ if (!Objects.isNull(request.getHeaders())) {`
	`103`	`+ for (Map.Entry<String, String> header : request.getHeaders().entrySet()) {`
`104`	`104`	`System.out.println("do filter: header key: " + header.getKey());`
`105`	`105`	`System.out.println("do filter: header value: " + header.getValue());`
`106`	`106`	`}`