Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 7b63aec

Browse files
liferoadtvalentyn
andauthored
Removed < 1.66 for grpcio (#34196)
* Removed < 1.66 for grpcio * Update sdks/python/setup.py Co-authored-by: tvalentyn <[email protected]> * updated the version upper bound * skip pip check for lint * try <1.71 * updated the grpcio range * use grpcio 1.73.1 --------- Co-authored-by: tvalentyn <[email protected]>
1 parent 4070b07 commit 7b63aec

2 files changed

Lines changed: 10 additions & 3 deletions

File tree

sdks/python/setup.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -366,9 +366,10 @@ def get_portability_package_data():
366366
'dill>=0.3.1.1,<0.3.2',
367367
'fastavro>=0.23.6,<2',
368368
'fasteners>=0.3,<1.0',
369-
# TODO(https://github.com/grpc/grpc/issues/37710): Unpin grpc
370-
'grpcio>=1.33.1,<2,!=1.48.0,!=1.59.*,!=1.60.*,!=1.61.*,!=1.62.0,!=1.62.1,<1.66.0; python_version <= "3.12"', # pylint: disable=line-too-long
371-
'grpcio>=1.67.0; python_version >= "3.13"',
369+
# any version between 1.68.0 and 1.73.0 is bad
370+
# external issue: https://github.com/grpc/grpc/issues/37710
371+
'grpcio>=1.33.1,<1.74.0,!=1.48.0,!=1.59.*,!=1.60.*,!=1.61.*,!=1.62.0,!=1.62.1,!=1.68.*,!=1.69.*,!=1.70.*,!=1.71.*,!=1.72.*,!=1.73.0; python_version <= "3.12"', # pylint: disable=line-too-long
372+
'grpcio>=1.73.1; python_version >= "3.13"',
372373
'hdfs>=2.1.0,<3.0.0',
373374
'httplib2>=0.8,<0.23.0',
374375
'jsonschema>=4.0.0,<5.0.0',

sdks/python/tox.ini

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,12 @@ deps =
167167
pylint==2.17.5
168168
isort==4.2.15
169169
flake8==4.0.1
170+
# https://github.com/grpc/grpc/issues/37660: ignore pip check
171+
commands_pre =
172+
python --version
173+
pip --version
174+
# pip check
175+
bash {toxinidir}/scripts/run_tox_cleanup.sh
170176
commands =
171177
pylint --version
172178
time {toxinidir}/scripts/run_pylint.sh

0 commit comments

Comments
 (0)