Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Unable to remove accounts from the UI/Accounts page using the main button #9904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NuxRo opened this issue Nov 7, 2024 · 11 comments
Open

Comments

@NuxRo
Copy link
Contributor

NuxRo commented Nov 7, 2024

ISSUE TYPE
  • Bug Report
COMPONENT NAME
UI
CLOUDSTACK VERSION
4.19.1.2
CONFIGURATION
OS / ENVIRONMENT
SUMMARY

In the UI it doesn't seem possible to select one or more accounts and Delete them from the list view, it must be done individually, their the accounts own menu Delete entry.

STEPS TO REPRODUCE
Go to UI -> Accounts, select one or more and try to delete it by using the "bin" icon up top near the search field. 
The button is greyed out.


screenshot

EXPECTED RESULTS
I should have been able to batch-delete the selected accounts by using the "bin" icon on the Accounts page.
ACTUAL RESULTS
Delete button stayed greyed out, unusable.
@abh1sar
Copy link
Collaborator

abh1sar commented Jan 25, 2025

hi @NuxRo
Do we really want group action for account deletion?
There is an issue regarding account deletion #9480 which mentions that account deletion is a destructive event (deletes all instances, volumes, snapshots etc). So some extra safety measures should be added so that user doesn't inadvertently delete an account. There is an open PR for it as well which makes user input the name of the account before deleting it #10242.
Please let me know your thoughts on this.

@NuxRo
Copy link
Contributor Author

NuxRo commented Jan 27, 2025

@abh1sar Well.. I don't know what to say.
Personally I'd like to have the option, but if the community thinks some users might shoot themselves in the foot with it then I guess I can make do with the api/cmk.

BTW, in the meanwhile I have discovered that one CAN indeed delete multiple accounts from the UI - just select the accounts you want to delete, then on first one (or any one of them) choose "delete" and all of them are removed. See screenshots below.

Image

Image

@DaanHoogland
Copy link
Contributor

@abh1sar @NuxRo , I think we can see this as a minor UI bug, The delete button should be not there or enabled, would you agree?
To answer the more serious functional question: I think it should be up to the operator (or even domain admin) if they want to be able to delete multiple accounts at once.

@DaanHoogland DaanHoogland modified the milestones: 4.19.2, 4.19.3 Feb 13, 2025
@abh1sar abh1sar self-assigned this Mar 12, 2025
@Imvedansh
Copy link
Contributor

@DaanHoogland @abh1sar I’d like to pick up this issue if it still needs to be worked on. Could you please confirm if someone is already addressing it?

@DaanHoogland
Copy link
Contributor

@Imvedansh , no PR has been associated with this issue yet, please feel free. It was assigned to @abh1sar , but i'm sure he'll forgive you if you beat him to it. ;)

@Imvedansh
Copy link
Contributor

Imvedansh commented Apr 11, 2025

On it! Sorry @abh1sar , repo race is on:)

@Imvedansh
Copy link
Contributor

@DaanHoogland
Multiple accounts should not be deleted in one go—they should be deleted individually to avoid potential disasters.

However, when I select multiple accounts, then click the dropdown and choose "Delete," even if I cancel the action, I can still delete multiple accounts from the main action. It even allows the current account to be deleted, as shown in the screenshot.

How do you think I should proceed?

Image

Refer #9480 , these features will conflict,

@DaanHoogland
Copy link
Contributor

@Imvedansh , i think the action of deleting multiple account should be available to those who have right to this API.
BUT ...
root admin and current account should not be able to be deleted. I think for the latter a fix is already implemented.

@Imvedansh
Copy link
Contributor

@DaanHoogland I agree,
But ...
with that it may not make much sense with extra security step in deleting accounts, WDYT?
Like here,
Image

@DaanHoogland
Copy link
Contributor

"DELETE ALL!" ;)

@Imvedansh
Copy link
Contributor

"DELETE ALL!" ;)

Going that road now :) .....

@abh1sar abh1sar removed their assignment Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants