-
Notifications
You must be signed in to change notification settings - Fork 26.6k
Fix/issue 15798 graceful shutdown #15973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arunikayadav42
wants to merge
4
commits into
apache:3.3
Choose a base branch
from
arunikayadav42:fix/issue-15798-graceful-shutdown
base: 3.3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
ad86035
Fix: Graceful shutdown by implementing DisposableBean (#15798)
arunikayadav42 43ac411
Test: Verify Dubbo graceful shutdown order (#15798)
arunikayadav42 5040001
Merge branch '3.3' into fix/issue-15798-graceful-shutdown
arunikayadav42 675b2a4
Style: Apply Spotless formatting
arunikayadav42 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91 changes: 91 additions & 0 deletions
91
...fig-spring/src/test/java/org/apache/dubbo/config/spring/context/GracefulShutdownTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.dubbo.config.spring.context; | ||
|
|
||
| import org.apache.dubbo.config.spring.util.DubboBeanUtils; | ||
| import org.apache.dubbo.rpc.model.ModuleModel; | ||
|
|
||
| import java.util.concurrent.atomic.AtomicBoolean; | ||
|
|
||
| import org.junit.jupiter.api.Assertions; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.springframework.beans.factory.DisposableBean; | ||
| import org.springframework.context.ApplicationContext; | ||
| import org.springframework.context.ApplicationContextAware; | ||
| import org.springframework.context.annotation.AnnotationConfigApplicationContext; | ||
| import org.springframework.context.annotation.Bean; | ||
| import org.springframework.context.annotation.Configuration; | ||
|
|
||
| public class GracefulShutdownTest { | ||
|
|
||
| @Test | ||
| public void testDubboShutdownOrder() { | ||
| AnnotationConfigApplicationContext context = new AnnotationConfigApplicationContext(); | ||
| context.register(DubboConfig.class); | ||
| context.refresh(); | ||
|
|
||
| MyTask myTask = context.getBean(MyTask.class); | ||
|
|
||
| // Ensure Dubbo is running | ||
| ModuleModel moduleModel = DubboBeanUtils.getModuleModel(context); | ||
| Assertions.assertFalse(moduleModel.isDestroyed(), "Module should be running"); | ||
|
|
||
| System.out.println("Closing context..."); | ||
| context.close(); | ||
| System.out.println("Context closed."); | ||
|
|
||
| Assertions.assertTrue( | ||
| myTask.verified.get(), "MyTask.destroy() should have been called and verified Dubbo status"); | ||
| } | ||
|
|
||
| @Configuration | ||
| static class DubboConfig { | ||
| @Bean | ||
| public DubboDeployApplicationListener dubboDeployApplicationListener() { | ||
| return new DubboDeployApplicationListener(); | ||
| } | ||
|
|
||
| @Bean | ||
| public MyTask myTask() { | ||
| return new MyTask(); | ||
| } | ||
| } | ||
|
|
||
| static class MyTask implements DisposableBean, ApplicationContextAware { | ||
| AtomicBoolean verified = new AtomicBoolean(false); | ||
| ApplicationContext applicationContext; | ||
|
|
||
| @Override | ||
| public void setApplicationContext(ApplicationContext applicationContext) { | ||
| this.applicationContext = applicationContext; | ||
| } | ||
|
|
||
| @Override | ||
| public void destroy() throws Exception { | ||
| System.out.println("MyTask destroying..."); | ||
| ModuleModel moduleModel = DubboBeanUtils.getModuleModel(applicationContext); | ||
| // If Dubbo is destroyed on ContextClosedEvent, this will be true. | ||
| // But we want it to be FALSE (still alive). | ||
| boolean destroyed = moduleModel.isDestroyed(); | ||
| System.out.println("Dubbo destroyed status in MyTask: " + destroyed); | ||
|
|
||
| if (!destroyed) { | ||
| verified.set(true); | ||
| } | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mvn spotless:apply