fix(series): mismatched dimension index when canOmitUnusedDimensions is true#20682
Merged
100pah merged 2 commits intoapache:masterfrom Mar 6, 2025
Merged
fix(series): mismatched dimension index when canOmitUnusedDimensions is true#20682100pah merged 2 commits intoapache:masterfrom
100pah merged 2 commits intoapache:masterfrom
Conversation
|
Thanks for your contribution! |
Contributor
Author
|
@Ovilia Could you help to review the PR? Thanks! |
Contributor
Author
|
@100pah @plainheart |
Contributor
Author
|
@pissang Could you help to review this PR? Thanks! |
100pah
approved these changes
Mar 6, 2025
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
plainheart
reviewed
Dec 20, 2025
Comment on lines
+321
to
+323
| if (zrUtil.isNumber(dimensionInfo.storeDimIndex)) { | ||
| dimIdx = dimensionInfo.storeDimIndex; | ||
| } |
Member
There was a problem hiding this comment.
This seems to lead a regression issue described in #21415. I would suggest fixing it in v6.1.0.
plainheart
added a commit
that referenced
this pull request
Dec 20, 2025
…o storeDimIndex mismatch. This regression was introduced in #20682
This was referenced Dec 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #20672
Brief Information
This pull request is in the type of:
What does this PR do?
fix(series): mismatched dimension index when
canOmitUnusedDimensionsis true.See more details in #20672
Fixed issues
#20672
Details
Before: What was the problem?
#20672
After: How does it behave after the fixing?
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information