Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Tests should explicitly check for schema_id#487

Merged
Fokko merged 1 commit intoapache:mainfrom
kevinjqliu:kevinjqliu/fix-schema-comparison
Mar 5, 2024
Merged

Tests should explicitly check for schema_id#487
Fokko merged 1 commit intoapache:mainfrom
kevinjqliu:kevinjqliu/fix-schema-comparison

Conversation

@kevinjqliu
Copy link
Contributor

@kevinjqliu kevinjqliu commented Mar 1, 2024 •
edited
Loading

This PR modifies tests to explicitly check schema_id when comparing Schema.
Related to #290

Previously, many tests were written with implicit schema_id checks. For example,

    assert table.schema() == Schema(
        NestedField(field_id=1, name='id', field_type=LongType(), required=False),
        NestedField(field_id=2, name='event_ts', field_type=TimestampType(), required=False),
        NestedField(field_id=3, name='str', field_type=StringType(), required=False),
        NestedField(field_id=4, name='col_string', field_type=StringType(), required=False),
        schema_id=1,
        identifier_field_ids=[],
    )

Since Schema.__eq__ does not check for schema_id, we never check the schema_id of the Schema

@kevinjqliu kevinjqliu force-pushed the kevinjqliu/fix-schema-comparison branch from 18c6c53 to f9711b3 Compare March 2, 2024 19:22
@kevinjqliu kevinjqliu changed the title Kevinjqliu/fix schema comparison Tests should explicitly check for schema_id Mar 2, 2024
@kevinjqliu kevinjqliu mentioned this pull request Mar 2, 2024
Closed
@kevinjqliu kevinjqliu marked this pull request as ready for review March 2, 2024 19:29
Fokko
Fokko approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the tests @kevinjqliu This would have caught the bug in #290 earlier 👍

@Fokko Fokko merged commit 9d01b02 into apache:main Mar 5, 2024
@kevinjqliu kevinjqliu deleted the kevinjqliu/fix-schema-comparison branch March 5, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fokko Fokko Fokko approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kevinjqliu @Fokko