Exclude Python 3.9.7 due to import error in catalog module#526
Merged
kevinjqliu merged 2 commits intoapache:mainfrom Aug 8, 2024
Merged
Exclude Python 3.9.7 due to import error in catalog module#526kevinjqliu merged 2 commits intoapache:mainfrom
kevinjqliu merged 2 commits intoapache:mainfrom
Conversation
281ef3a to
9969037
Compare
Collaborator
Author
|
Related python issue: https://bugs.python.org/issue45081 |
9969037 to
1639342
Compare
Collaborator
|
This sounds like a great idea @ndrluis - thank you for identifying this issue and putting in the fix. Could we ask for you to rebase your PR against the current main, and run |
Collaborator
Author
|
@sungwy Done! |
Adjusts the supported Python versions to exclude 3.9.7, as importing the catalog module on this version results in an unexpected error. The issue does not occur in versions 3.9.6 or 3.9.8, indicating a specific incompatibility with Python 3.9.7.
4b11524 to
e9d37a6
Compare
Contributor
|
With this change, what do I see as a user with python 3.9.7? Does it show that 3.9.7 is not supported and I should use a supported version? |
Collaborator
Author
|
Yes @kevinjqliu! This is a example |
sungwy
approved these changes
Aug 6, 2024
kevinjqliu
reviewed
Aug 6, 2024
Co-authored-by: Kevin Liu <[email protected]>
a82b6e0 to
d88f199
Compare
kevinjqliu
approved these changes
Aug 8, 2024
Contributor
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM!
I've tested with python 3.9.7 and running make install
Here's the error log
The currently activated Python version 3.9.7 is not supported by the project (>=3.8, <4.0, !=3.9.7).
Trying to find and use a compatible version.
sungwy
pushed a commit
that referenced
this pull request
Aug 9, 2024
* Exclude Python 3.9.7 due to import error in catalog module Adjusts the supported Python versions to exclude 3.9.7, as importing the catalog module on this version results in an unexpected error. The issue does not occur in versions 3.9.6 or 3.9.8, indicating a specific incompatibility with Python 3.9.7. * Update pyproject.toml Co-authored-by: Kevin Liu <[email protected]> --------- Co-authored-by: Kevin Liu <[email protected]>
sungwy
pushed a commit
that referenced
this pull request
Aug 9, 2024
* Exclude Python 3.9.7 due to import error in catalog module Adjusts the supported Python versions to exclude 3.9.7, as importing the catalog module on this version results in an unexpected error. The issue does not occur in versions 3.9.6 or 3.9.8, indicating a specific incompatibility with Python 3.9.7. * Update pyproject.toml Co-authored-by: Kevin Liu <[email protected]> --------- Co-authored-by: Kevin Liu <[email protected]>
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
* Exclude Python 3.9.7 due to import error in catalog module Adjusts the supported Python versions to exclude 3.9.7, as importing the catalog module on this version results in an unexpected error. The issue does not occur in versions 3.9.6 or 3.9.8, indicating a specific incompatibility with Python 3.9.7. * Update pyproject.toml Co-authored-by: Kevin Liu <[email protected]> --------- Co-authored-by: Kevin Liu <[email protected]>
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
* Exclude Python 3.9.7 due to import error in catalog module Adjusts the supported Python versions to exclude 3.9.7, as importing the catalog module on this version results in an unexpected error. The issue does not occur in versions 3.9.6 or 3.9.8, indicating a specific incompatibility with Python 3.9.7. * Update pyproject.toml Co-authored-by: Kevin Liu <[email protected]> --------- Co-authored-by: Kevin Liu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjusts the supported Python versions to exclude 3.9.7, as importing the catalog module on this version results in an unexpected error. The issue does not occur in versions 3.9.6 or 3.9.8, indicating a specific incompatibility with Python 3.9.7.
Related to #500, #497