Update formatting of prerequisites-requirements error to improve readability

slawekjaranowski · slawekjaranowski · commit ec21f4bf223c · 2025-12-06T18:43:51.000+01:00
Message at the end of error line is not readable ... so add some new lines and tabs to make it more readable
diff --git a/maven-core/src/main/java/org/apache/maven/plugin/MavenPluginPrerequisitesChecker.java b/maven-core/src/main/java/org/apache/maven/plugin/MavenPluginPrerequisitesChecker.java
@@ -31,7 +31,7 @@
 public interface MavenPluginPrerequisitesChecker extends Consumer<PluginDescriptor> {
     /**
      *
-     * @param pluginDescriptor
+     * @param pluginDescriptor the plugin descriptor to check
      * @throws IllegalStateException in case the checked prerequisites are not met
      */
     @Override
diff --git a/maven-core/src/main/java/org/apache/maven/plugin/PluginIncompatibleException.java b/maven-core/src/main/java/org/apache/maven/plugin/PluginIncompatibleException.java
@@ -26,10 +26,6 @@
 public class PluginIncompatibleException extends PluginManagerException {
 
     public PluginIncompatibleException(Plugin plugin, String message) {
-        this(plugin, message, null);
-    }
-
-    public PluginIncompatibleException(Plugin plugin, String message, Throwable cause) {
-        super(plugin, message, cause);
+        super(plugin, message, (Throwable) null);
     }
 }
diff --git a/maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultMavenPluginManager.java b/maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultMavenPluginManager.java
@@ -296,15 +296,15 @@ public void checkPrerequisites(PluginDescriptor pluginDescriptor) throws PluginI
         });
         // aggregate all exceptions
         if (!prerequisiteExceptions.isEmpty()) {
+            String ln = System.lineSeparator();
             String messages = prerequisiteExceptions.stream()
                     .map(IllegalStateException::getMessage)
-                    .collect(Collectors.joining(", "));
+                    .collect(Collectors.joining(ln + '\t'));
             PluginIncompatibleException pie = new PluginIncompatibleException(
                     pluginDescriptor.getPlugin(),
-                    "The plugin " + pluginDescriptor.getId() + " has unmet prerequisites: " + messages,
-                    prerequisiteExceptions.get(0));
-            // the first exception is added as cause, all other ones as suppressed exceptions
-            prerequisiteExceptions.stream().skip(1).forEach(pie::addSuppressed);
+                    ln + "The plugin " + pluginDescriptor.getId() + " has unmet prerequisites: " + ln + '\t'
+                            + messages);
+            prerequisiteExceptions.forEach(pie::addSuppressed);
             throw pie;
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@`
`31`	`31`	`public interface MavenPluginPrerequisitesChecker extends Consumer<PluginDescriptor> {`
`32`	`32`	`/**`
`33`	`33`	`*`
`34`		`- * @param pluginDescriptor`
	`34`	`+ * @param pluginDescriptor the plugin descriptor to check`
`35`	`35`	`* @throws IllegalStateException in case the checked prerequisites are not met`
`36`	`36`	`*/`
`37`	`37`	`@Override`
Original file line number	Diff line number	Diff line change
`@@ -26,10 +26,6 @@`
`26`	`26`	`public class PluginIncompatibleException extends PluginManagerException {`
`27`	`27`
`28`	`28`	`public PluginIncompatibleException(Plugin plugin, String message) {`
`29`		`- this(plugin, message, null);`
`30`		`- }`
`31`		`-`
`32`		`- public PluginIncompatibleException(Plugin plugin, String message, Throwable cause) {`
`33`		`- super(plugin, message, cause);`
	`29`	`+ super(plugin, message, (Throwable) null);`
`34`	`30`	`}`
`35`	`31`	`}`