Sebastian Ratz opened MDEPLOY-311 and commented

Regression in #26

Property passed via -Dpackaging is not considered anymore during upload. Instead, packaging is always derived from the file name.

To reproduce:

$ mvn -Dfile=foo.zip -DgroupId=com.bar -Dclassifier=baz -DrepositoryId=deploy.snapshots -DartifactId=foo -D{*}packaging=alterantivepackaging{*} -Dversion=1.0.0-SNAPSHOT deploy:{*}3.0.0-M2{*}:deploy-file -Durl=file:./repo
...
Uploading to deploy.snapshots: file:./repo/com/bar/foo/1.0.0-SNAPSHOT/foo-1.0.0-20230703.093021-2-baz{*}.alterantivepackaging{*}
...

$ mvn -Dfile=foo.zip -DgroupId=com.bar -Dclassifier=baz -DrepositoryId=deploy.snapshots -DartifactId=foo -Dpackaging=alterantivepackaging -Dversion=1.0.0-SNAPSHOT deploy:{*}3.0.0{*}:deploy-file -Durl=file:./repo
...
Uploading to deploy.snapshots: file:./repo/com/bar/foo/1.0.0-SNAPSHOT/foo-1.0.0-20230703.093125-3-baz.zip
...

The problematic line is

https://github.com/apache/maven-deploy-plugin/blob/707ab61615606053eb816e7c96d1fc276a80a47f/src/main/java/org/apache/maven/plugins/deploy/DeployFileMojo.java#L278C58-L278C96

Here,
packaging
should be used instead of
isFilePom ? "pom" : getExtension(file)

Affects: 3.0.0, 3.1.0, 3.1.1

Issue Links:

• MDEPLOY-297 [REGRESSION] deploy-file no longer honor 'packaging' parameter
  ("fixes")
• MDEPLOY-321 -Dpackaging= is ignored when using mvn deploy:deploy-file
  ("fixes")

Remote Links:

• GitHub Pull Request #42
  
• GitHub Pull Request #71
  

1 votes, 3 watchers