Add null checks for modelId in PluginWrapper

cpfeiffer · slawekjaranowski · commit 2da7a68b4d8d · 2026-04-27T19:22:35.000+02:00
In certain special scenarios (virtual maven-tiles), modelId can be null.
diff --git a/enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/utils/PluginWrapper.java b/enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/utils/PluginWrapper.java
@@ -81,6 +81,9 @@ public static Optional<Boolean> isVersionFromDefaultLifecycleBindings(InputLocat
         }
 
         String modelId = versionLocation.getSource().getModelId();
+        if (modelId == null) {
+            return Optional.empty();
+        }
         return Optional.of(
                 modelId.startsWith("org.apache.maven:maven-core:") && modelId.endsWith(":default-lifecycle-bindings"));
     }
@@ -100,6 +103,9 @@ public static Optional<Boolean> isVersionFromSuperpom(InputLocationTracker o) {
         }
 
         String modelId = versionLocation.getSource().getModelId();
+        if (modelId == null) {
+            return Optional.empty();
+        }
         return Optional.of(
                 modelId.startsWith("org.apache.maven:maven-model-builder:") && modelId.endsWith(":super-pom"));
     }

Original file line number	Diff line number	Diff line change
`@@ -81,6 +81,9 @@ public static Optional<Boolean> isVersionFromDefaultLifecycleBindings(InputLocat`
`81`	`81`	`}`
`82`	`82`
`83`	`83`	`String modelId = versionLocation.getSource().getModelId();`
	`84`	`+ if (modelId == null) {`
	`85`	`+ return Optional.empty();`
	`86`	`+ }`
`84`	`87`	`return Optional.of(`
`85`	`88`	`modelId.startsWith("org.apache.maven:maven-core:") && modelId.endsWith(":default-lifecycle-bindings"));`
`86`	`89`	`}`
`@@ -100,6 +103,9 @@ public static Optional<Boolean> isVersionFromSuperpom(InputLocationTracker o) {`
`100`	`103`	`}`
`101`	`104`
`102`	`105`	`String modelId = versionLocation.getSource().getModelId();`
	`106`	`+ if (modelId == null) {`
	`107`	`+ return Optional.empty();`
	`108`	`+ }`
`103`	`109`	`return Optional.of(`
`104`	`110`	`modelId.startsWith("org.apache.maven:maven-model-builder:") && modelId.endsWith(":super-pom"));`
`105`	`111`	`}`