[MPLUGIN-453] Fix Temporary File Information Disclosure (#176)

JLLeitschuh · TeamModerne · gnodet · web-flow · commit 52be8fafda3a · 2023-02-13T11:28:27.000+01:00
This fixes temporary file information disclosure vulnerability due to the use of the vulnerable `File.createTempFile()` method. The vulnerability is fixed by using the `Files.createTempFile()` method which sets the correct posix permissions. Weakness: CWE-377: Insecure Temporary File Severity: Medium CVSSS: 5.5 Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.SecureTempFileCreation) Reported-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com> Bug-tracker: JLLeitschuh/security-research#18 Co-authored-by: Moderne <team@moderne.io> Co-authored-by: Guillaume Nodet <gnodet@gmail.com>
diff --git a/maven-script/maven-script-ant/src/test/java/org/apache/maven/script/ant/AntMojoWrapperTest.java b/maven-script/maven-script-ant/src/test/java/org/apache/maven/script/ant/AntMojoWrapperTest.java
@@ -26,6 +26,7 @@
 import java.io.Reader;
 import java.net.URISyntaxException;
 import java.net.URL;
+import java.nio.file.Files;
 import java.nio.file.Paths;
 import java.util.ArrayList;
 import java.util.Collections;
@@ -140,7 +141,7 @@ private List<String> run(String pluginXml)
 
         File pluginXmlFile = Paths.get(resource.toURI()).toFile();
 
-        File jarFile = File.createTempFile("AntMojoWrapperTest.", ".test.jar");
+        File jarFile = Files.createTempFile("AntMojoWrapperTest.", ".test.jar").toFile();
         jarFile.deleteOnExit();
 
         JarArchiver archiver = new JarArchiver();
