fix(state): add link header processor without links (#5888)

soyuka · web-flow · commit 0c50d4ceba9d · 2023-10-17T14:56:17.000+02:00
fixes #5886
diff --git a/src/State/Processor/AddLinkHeaderProcessor.php b/src/State/Processor/AddLinkHeaderProcessor.php
@@ -37,7 +37,7 @@ public function process(mixed $data, Operation $operation, array $uriVariables =
 
         // We add our header here as Symfony does it only for the main Request and we want it to be done on errors (sub-request) as well
         $linksProvider = $request->attributes->get('_api_platform_links');
-        if ($this->serializer && ($links = $linksProvider->getLinks())) {
+        if ($this->serializer && ($links = $linksProvider?->getLinks())) {
             $response->headers->set('Link', $this->serializer->serialize($links));
         }
 
diff --git a/src/State/Tests/Processor/AddLinkHeaderProcessorTest.php b/src/State/Tests/Processor/AddLinkHeaderProcessorTest.php
@@ -0,0 +1,32 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <dunglas@gmail.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace ApiPlatform\State\Tests\Processor;
+
+use ApiPlatform\Metadata\Get;
+use ApiPlatform\State\Processor\AddLinkHeaderProcessor;
+use ApiPlatform\State\ProcessorInterface;
+use PHPUnit\Framework\TestCase;
+
+class AddLinkHeaderProcessorTest extends TestCase
+{
+    public function testWithoutLinks(): void
+    {
+        $data = new \stdClass();
+        $operation = new Get();
+        $decorated = $this->createStub(ProcessorInterface::class);
+        $decorated->method('process')->willReturn($data);
+        $processor = new AddLinkHeaderProcessor($decorated);
+        $this->assertEquals($data, $processor->process($data, $operation));
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ public function process(mixed $data, Operation $operation, array $uriVariables =`
`37`	`37`
`38`	`38`	`// We add our header here as Symfony does it only for the main Request and we want it to be done on errors (sub-request) as well`
`39`	`39`	`$linksProvider = $request->attributes->get('_api_platform_links');`
`40`		`- if ($this->serializer && ($links = $linksProvider->getLinks())) {`
	`40`	`+ if ($this->serializer && ($links = $linksProvider?->getLinks())) {`
`41`	`41`	`$response->headers->set('Link', $this->serializer->serialize($links));`
`42`	`42`	`}`
`43`	`43`